Establish precedence for embed over serializeIds #1074
Merged
+103
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix and the tests! |
|
Thank you for the quick turnaround on the fix! |
kevinansfield
referenced
this pull request
in TryGhost/Ghost
Feb 28, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [miragejs](https://togithub.com/miragejs/miragejs) | [`0.1.45` -> `0.1.47`](https://renovatebot.com/diffs/npm/miragejs/0.1.45/0.1.47) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>miragejs/miragejs</summary> ### [`v0.1.47`](https://togithub.com/miragejs/miragejs/releases/tag/v0.1.47) [Compare Source](https://togithub.com/miragejs/miragejs/compare/v0.1.46...v0.1.47) 🚀 Enhancements - Typescript: Allow arbitrary model updates, not only Collections by [@​lanhhv84](https://togithub.com/lanhhv84) in [https://github.com/miragejs/miragejs/pull/1066](https://togithub.com/miragejs/miragejs/pull/1066) 🐛 Bugfixes - Establish precedence for embed over serializeIds by [@​NoneOfMaster](https://togithub.com/NoneOfMaster) in [https://github.com/miragejs/miragejs/pull/1074](https://togithub.com/miragejs/miragejs/pull/1074) #### New Contributors - [@​lanhhv84](https://togithub.com/lanhhv84) made their first contribution in [https://github.com/miragejs/miragejs/pull/1066](https://togithub.com/miragejs/miragejs/pull/1066) **Full Changelog**: miragejs/miragejs@v0.1.46...v0.1.47 ### [`v0.1.46`](https://togithub.com/miragejs/miragejs/releases/tag/v0.1.46) [Compare Source](https://togithub.com/miragejs/miragejs/compare/v0.1.45...v0.1.46) #### What's Changed 🚀 **Enhancements** - Support selected embedded relationships by [@​NoneOfMaster](https://togithub.com/NoneOfMaster) in [https://github.com/miragejs/miragejs/pull/850](https://togithub.com/miragejs/miragejs/pull/850) - Add resource function type definition by [@​morganmspencer](https://togithub.com/morganmspencer) in [https://github.com/miragejs/miragejs/pull/1059](https://togithub.com/miragejs/miragejs/pull/1059) 🐛 **Bugfixes** - Fixed timing being incorrectly passed to pretender by [@​cah-brian-gantzler](https://togithub.com/cah-brian-gantzler) in [https://github.com/miragejs/miragejs/pull/1051](https://togithub.com/miragejs/miragejs/pull/1051) - Fix includes query params by [@​mansona](https://togithub.com/mansona) in [https://github.com/miragejs/miragejs/pull/1064](https://togithub.com/miragejs/miragejs/pull/1064) 🗂 **Types** - Align passthrough type declaration with implementation by [@​brzosthub](https://togithub.com/brzosthub) in [https://github.com/miragejs/miragejs/pull/1061](https://togithub.com/miragejs/miragejs/pull/1061) #### New Contributors - [@​brzosthub](https://togithub.com/brzosthub) made their first contribution in [https://github.com/miragejs/miragejs/pull/1061](https://togithub.com/miragejs/miragejs/pull/1061) - [@​NoneOfMaster](https://togithub.com/NoneOfMaster) made their first contribution in [https://github.com/miragejs/miragejs/pull/850](https://togithub.com/miragejs/miragejs/pull/850) - [@​morganmspencer](https://togithub.com/morganmspencer) made their first contribution in [https://github.com/miragejs/miragejs/pull/1059](https://togithub.com/miragejs/miragejs/pull/1059) - [@​mansona](https://togithub.com/mansona) made their first contribution in [https://github.com/miragejs/miragejs/pull/1064](https://togithub.com/miragejs/miragejs/pull/1064) **Full Changelog**: miragejs/miragejs@v0.1.45...v0.1.46 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzQuMTE2LjEifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#850 introduced support for selectively serializing embedded relationships.
This PR should close #1073 which points out a collision which was also introduced between
serializeIds(set toalwaysas it is in theActiveModelSerializerand theRestSerializer) and the intended new functionality.