Fix stale request object when an explicit serializer type is passed #1103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #885. (Was likely introduced here)
Although it does solve the issue in the least invasive way, the bug could persist in setups where the
serialize()
method is overridden, because while therequest
argument itself is documented, the doc suggests it's fine to throw it away. Also, it doesn't quite fix the underlying issue, namely that serializer & serializer-registry state isn't reset across requests. For example, whenserializerRegistry.serializerFor
is used to obtain the serializer, the request object must be assigned manually to the serializer, otherwise it'd break the same as before.Nevertheless, all other solutions would end up being much more complex and have more likelihood of breaking some Mirage setups.