fix corner case in unsafe (#4783)

mishoo · Mar 16, 2021 · 77c9116 · 77c9116
1 parent e821787
commit 77c9116
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 2 deletions.
diff --git a/lib/compress.js b/lib/compress.js
@@ -8522,11 +8522,12 @@ merge(Compressor.prototype, {
             } else if (exp instanceof AST_Dot) switch (exp.property) {
               case "toString":
                 // x.toString() ---> "" + x
-                if (self.args.length == 0 && !exp.expression.may_throw_on_access(compressor)) {
+                var expr = exp.expression;
+                if (self.args.length == 0 && !(expr.may_throw_on_access(compressor) || expr instanceof AST_Super)) {
                     return make_node(AST_Binary, self, {
                         operator: "+",
                         left: make_node(AST_String, self, { value: "" }),
-                        right: exp.expression,
+                        right: expr,
                     }).optimize(compressor);
                 }
                 break;

diff --git a/test/compress/pure_getters.js b/test/compress/pure_getters.js
@@ -1490,3 +1490,49 @@ issue_4751: {
         };
     }
 }
+
+super_toString: {
+    options = {
+        pure_getters: true,
+        unsafe: true,
+    }
+    input: {
+        console.log({
+            f() {
+                return super.toString();
+            },
+        }.f());
+    }
+    expect: {
+        console.log({
+            f() {
+                return super.toString();
+            },
+        }.f());
+    }
+    expect_stdout: "[object Object]"
+    node_version: ">=4"
+}
+
+this_toString: {
+    options = {
+        pure_getters: true,
+        unsafe: true,
+    }
+    input: {
+        console.log({
+            f() {
+                return this.toString();
+            },
+        }.f());
+    }
+    expect: {
+        console.log({
+            f() {
+                return "" + this;
+            },
+        }.f());
+    }
+    expect_stdout: "[object Object]"
+    node_version: ">=4"
+}