fix corner case in side_effects (#5024)

fixes #5023
mishoo · Jun 22, 2021 · 95090db · 95090db
1 parent 7c5b6f3
commit 95090db
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 1 deletion.
diff --git a/lib/compress.js b/lib/compress.js
@@ -5275,7 +5275,7 @@ merge(Compressor.prototype, {
                 || any(this.body, compressor);
         });
         def(AST_SymbolRef, function(compressor) {
-            return !this.is_declared(compressor);
+            return !this.is_declared(compressor) || !can_drop_symbol(this, compressor);
         });
         def(AST_Template, function(compressor) {
             if (any(this.expressions, compressor)) return true;

diff --git a/test/compress/awaits.js b/test/compress/awaits.js
@@ -1869,3 +1869,49 @@ issue_5019_3: {
     ]
     node_version: ">=8"
 }
+
+issue_5023_1: {
+    options = {
+        awaits: true,
+        reduce_vars: true,
+        side_effects: true,
+    }
+    input: {
+        (async function() {
+            let a = a;
+        })();
+        console.log("PASS");
+    }
+    expect: {
+        (async function() {
+            let a = a;
+        })();
+        console.log("PASS");
+    }
+    expect_stdout: "PASS"
+    node_version: ">=8"
+}
+
+issue_5023_2: {
+    options = {
+        awaits: true,
+        reduce_vars: true,
+        side_effects: true,
+    }
+    input: {
+        (async function() {
+            let a;
+            a = a;
+        })();
+        console.log("PASS");
+    }
+    expect: {
+        (function() {
+            let a;
+            a = a;
+        })();
+        console.log("PASS");
+    }
+    expect_stdout: "PASS"
+    node_version: ">=8"
+}