enhance: ノート詳細ページでリプライ一覧と引用一覧を別々に表示するように #13006
Open
+247
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/frontend
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -56007,6 +56007,174 @@
}
}
},
+ "/notes/quotes": {
+ "post": {
+ "operationId": "notes___quotes",
+ "summary": "notes/quotes",
+ "description": "No description provided.\n\n**Credential required**: *No*",
+ "externalDocs": {
+ "description": "Source code",
+ "url": "https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/server/api/endpoints/notes/quotes.ts"
+ },
+ "tags": [
+ "notes"
+ ],
+ "requestBody": {
+ "required": true,
+ "content": {
+ "application/json": {
+ "schema": {
+ "type": "object",
+ "properties": {
+ "noteId": {
+ "type": "string",
+ "format": "misskey:id"
+ },
+ "sinceId": {
+ "type": "string",
+ "format": "misskey:id"
+ },
+ "untilId": {
+ "type": "string",
+ "format": "misskey:id"
+ },
+ "limit": {
+ "type": "integer",
+ "minimum": 1,
+ "maximum": 100,
+ "default": 10
+ }
+ },
+ "required": [
+ "noteId"
+ ]
+ }
+ }
+ }
+ },
+ "responses": {
+ "200": {
+ "description": "OK (with results)",
+ "content": {
+ "application/json": {
+ "schema": {
+ "type": "array",
+ "items": {
+ "type": "object",
+ "$ref": "#/components/schemas/Note"
+ }
+ }
+ }
+ }
+ },
+ "400": {
+ "description": "Client error",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/Error"
+ },
+ "examples": {
+ "INVALID_PARAM": {
+ "value": {
+ "error": {
+ "message": "Invalid param.",
+ "code": "INVALID_PARAM",
+ "id": "3d81ceae-475f-4600-b2a8-2bc116157532"
+ }
+ }
+ }
+ }
+ }
+ }
+ },
+ "401": {
+ "description": "Authentication error",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/Error"
+ },
+ "examples": {
+ "CREDENTIAL_REQUIRED": {
+ "value": {
+ "error": {
+ "message": "Credential required.",
+ "code": "CREDENTIAL_REQUIRED",
+ "id": "1384574d-a912-4b81-8601-c7b1c4085df1"
+ }
+ }
+ }
+ }
+ }
+ }
+ },
+ "403": {
+ "description": "Forbidden error",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/Error"
+ },
+ "examples": {
+ "AUTHENTICATION_FAILED": {
+ "value": {
+ "error": {
+ "message": "Authentication failed. Please ensure your token is correct.",
+ "code": "AUTHENTICATION_FAILED",
+ "id": "b0a7f5f8-dc2f-4171-b91f-de88ad238e14"
+ }
+ }
+ }
+ }
+ }
+ }
+ },
+ "418": {
+ "description": "I'm Ai",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/Error"
+ },
+ "examples": {
+ "I_AM_AI": {
+ "value": {
+ "error": {
+ "message": "You sent a request to Ai-chan, Misskey's showgirl, instead of the server.",
+ "code": "I_AM_AI",
+ "id": "60c46cd1-f23a-46b1-bebe-5d2b73951a84"
+ }
+ }
+ }
+ }
+ }
+ }
+ },
+ "500": {
+ "description": "Internal server error",
+ "content": {
+ "application/json": {
+ "schema": {
+ "$ref": "#/components/schemas/Error"
+ },
+ "examples": {
+ "INTERNAL_ERROR": {
+ "value": {
+ "error": {
+ "message": "Internal error occurred. Please contact us if the error persists.",
+ "code": "INTERNAL_ERROR",
+ "id": "5d37dbcb-891e-41ca-a3d6-e690c97775ac"
+ }
+ }
+ }
+ }
+ }
+ }
+ }
+ }
+ }
+ },
"/notes/reactions": {
"get": {
"operationId": "notes___reactions", |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13006 +/- ##
===========================================
+ Coverage 65.01% 66.24% +1.22%
===========================================
Files 989 993 +4
Lines 112995 117640 +4645
Branches 5790 5837 +47
===========================================
+ Hits 73460 77926 +4466
- Misses 38093 39683 +1590
+ Partials 1442 31 -1411 ☔ View full report in Codecov by Sentry. |
5 tasks
Comment on lines
149
to
155
| <div v-if="tab === 'replies'" :class="$style.tab_replies"> | ||
| <MkPagination :pagination="repliesPagination" :disableAutoLoad="true"> | ||
| <template #default="{ items }"> | ||
| <MkNoteSub v-for="item in items" :key="item.id" :note="item" :class="$style.reply" :detail="true"/> | ||
| </template> | ||
| </MkPagination> | ||
| </div> |
There was a problem hiding this comment.
返信が勝手にfetchされるのを防ぎたいので「返信を見る」ボタンは残してほしい（引用RNのほうも同様）
There was a problem hiding this comment.
個人的にはいちいちロードボタンを押すのが面倒なので自動読み込みもできるようにして欲しいです
There was a problem hiding this comment.
利用者的には面倒だろうけど、運営者的には自動ロードされるとちょっと困りそう
There was a problem hiding this comment.
返信タブのもともとの挙動にあわせるのがよさそう
There was a problem hiding this comment.
初期ロードのノート数を少なくした上で初回のロードだけは自動にするか
|
@GrapeApple0 レビューしました🙏🙏 |
これやったらマージ可能 |
やるか |
|
リノートと引用が近いものだと思っているから隣接していて欲しい気持ちがややある（けどこれはもはや好みの問題かも） |
そうする |
|
デザインと挙動を修正したので概ね大丈夫かも
|
|
|
うーむ |
|
今それらってGET対応してたっけ |
|
してないはず |
MkNoteSubは階層を辿って全部読み込んじゃうのか |
…ple0/misskey into split-replies-and-quotes
結局これにした |
|
コンフリクト解消 |
|
コンフリクト解消 |
|
コンフリクト解消 |
|
👀 |
|
コンフリクト解消 |
|
@GrapeApple0 どうされました？ |
|
コンフリクト解消:angry_ai::angry_ai::angry_ai: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ノート詳細ページでリプライ一覧と引用一覧を別々に表示するようにしました
Why
fix: #12116
Additional info (optional)
related: https://misskey.04.si/notes/9oij2d26dn (notes/repliesを使うようにし、paginationを使うようにしたため)
Checklist