fix(backend): チャンネルフォロー一覧のsinceId/untilIdによる絞り込みが上手く動いていないのを修正 #13698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13698 +/- ##
============================================
- Coverage 77.99% 64.94% -13.06%
============================================
Files 185 986 +801
Lines 25454 111667 +86213
Branches 486 5703 +5217
============================================
+ Hits 19853 72522 +52669
- Misses 5594 37711 +32117
- Partials 7 1434 +1427 ☔ View full report in Codecov by Sentry. |
|
このPRによるapi.jsonの差分 差分はこちら |
samunohito
commented
Apr 13, 2024
| q.orderBy(`${q.alias}.id`, 'DESC'); | ||
| q.andWhere(`${q.alias}.${targetColumn} > :sinceId`, { sinceId: sinceId }); | ||
| q.andWhere(`${q.alias}.${targetColumn} < :untilId`, { untilId: untilId }); | ||
| q.orderBy(`${q.alias}.${targetColumn}`, 'DESC'); |
There was a problem hiding this comment.
SELECT
"MiChannelFollowing"."id" AS "MiChannelFollowing_id",
"MiChannelFollowing"."followeeId" AS "MiChannelFollowing_followeeId",
"MiChannelFollowing"."followerId" AS "MiChannelFollowing_followerId"
FROM
"channel_following" "MiChannelFollowing"
WHERE
"MiChannelFollowing"."followeeId" < $ 1
AND "MiChannelFollowing"."followerId" = $ 2
ORDER BY
"MiChannelFollowing"."followeeId" DESC
LIMIT
30↑のような感じで、外から任意のIDカラムを条件として使用できるようにしました。
省略時は従来通りidを使います
|
channel.idをIDとして与えている箇所って具体的にどこかしら？ |
|
見た感じバックエンドは現行の実装で何も問題なさそうだった |
|
（いまコメントに気が付いた） |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
チャンネルのフォロー一覧を返すAPIにて、sinceId/untilIdの比較条件として与えているIDに間違いがあるのを直します（与えられているIDはchannel.idだが、比較先のIDはchannel_following.id）
これにより、チャンネルフォロー一覧から結果が抜け落ちる現象が改善されます。
Why
fix #12175
Additional info (optional)
実際にチャンネルを大量に作成＆お気に入り登録し、歯抜けにならないことを確認。
Checklist