Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(backend): remove unnecessary find user queries #13762

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

zyoshoka
Copy link
Contributor

What

UsersRepository に対する不要な再取得が生じている部分を修正します。

Why

不要なクエリを減らすことによるパフォーマンス改善

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Apr 29, 2024
Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 65.07%. Comparing base (e2ff5f5) to head (c78afdd).

Files Patch % Lines
...ckend/src/server/api/endpoints/i/delete-account.ts 20.00% 4 Missing ⚠️
...ackend/src/server/api/endpoints/blocking/create.ts 0.00% 3 Missing ⚠️
...ackend/src/server/api/endpoints/blocking/delete.ts 25.00% 3 Missing ⚠️
...kages/backend/src/server/api/endpoints/i/update.ts 0.00% 3 Missing ⚠️
packages/backend/src/core/DeleteAccountService.ts 33.33% 2 Missing ⚠️
...ges/backend/src/core/activitypub/ApInboxService.ts 33.33% 2 Missing ⚠️
.../src/server/api/endpoints/admin/accounts/create.ts 50.00% 1 Missing ⚠️
...ackend/src/server/api/endpoints/admin/show-user.ts 0.00% 1 Missing ⚠️
...end/src/server/api/endpoints/i/regenerate-token.ts 0.00% 1 Missing ⚠️
...backend/src/server/api/endpoints/notes/unrenote.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13762       +/-   ##
============================================
- Coverage    77.92%   65.07%   -12.85%     
============================================
  Files          185      985      +800     
  Lines        25535   111880    +86345     
  Branches       487     4456     +3969     
============================================
+ Hits         19897    72811    +52914     
- Misses        5631    39038    +33407     
- Partials         7       31       +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Apr 29, 2024

今回変更された箇所は多分全て必要な再取得だと思われる(キャッシュを無視するための再取得)

@syuilo
Copy link
Member

syuilo commented Apr 29, 2024

いやそんなことはないな

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants