Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): read:admin:show-userread:admin:show-users を統合 #13798

Merged
merged 4 commits into from
May 23, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented May 6, 2024

What

Why

Fix #13791

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@syuilo
Copy link
Member

syuilo commented May 6, 2024

これ権限分かれてる必要なさそう

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented May 23, 2024

これ権限分かれてる必要なさそう

統一できた(と思う)

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/misskey-js labels May 23, 2024
@kakkokari-gtyih kakkokari-gtyih changed the title fix(frontend): 同じdisplayNameの権限があるのを修正 fix(backend): 一部の権限を統一 May 23, 2024
@kakkokari-gtyih kakkokari-gtyih changed the title fix(backend): 一部の権限を統一 fix(backend): read:admin:show-userread:admin:show-users を統合 May 23, 2024
@kakkokari-gtyih
Copy link
Contributor Author

これread:admin:show-usersだけのトークンを発行してた場合どうなるんだろう

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.42%. Comparing base (83a9aa4) to head (b4b167d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #13798   +/-   ##
========================================
  Coverage    66.42%   66.42%           
========================================
  Files          990      990           
  Lines       116887   116887           
  Branches      5851     5827   -24     
========================================
+ Hits         77640    77647    +7     
+ Misses       37807    37800    -7     
  Partials      1440     1440           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 23, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -11903,7 +11903,7 @@
       "post": {
         "operationId": "admin___show-users",
         "summary": "admin/show-users",
-        "description": "No description provided.\n\n**Credential required**: *Yes* / **Permission**: *read:admin:show-users*",
+        "description": "No description provided.\n\n**Credential required**: *Yes* / **Permission**: *read:admin:show-user*",
         "externalDocs": {
           "description": "Source code",
           "url": "https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/server/api/endpoints/admin/show-users.ts"

Get diff files from Workflow Page

@kakkokari-gtyih
Copy link
Contributor Author

これread:admin:show-usersだけのトークンを発行してた場合どうなるんだろう

CHANGELOGに書いた

@syuilo syuilo merged commit e0b4799 into develop May 23, 2024
30 checks passed
@syuilo syuilo deleted the fix-13791 branch May 23, 2024 08:29
@syuilo
Copy link
Member

syuilo commented May 23, 2024

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

アクセストークン作成画面に同じ名前の権限がある
2 participants