Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pnpm@9.0.6 to pnpm@9.1.0 #13814

Closed

Conversation

samunohito
Copy link
Member

@samunohito samunohito commented May 9, 2024

What

package.jsonに記述されているpnpmのバージョンを上げました

Why

fix #13813

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@samunohito samunohito marked this pull request as ready for review May 9, 2024 23:49
@zyoshoka
Copy link
Contributor

確か corepack up するとバリデーション用のハッシュがついてくるのでそれで更新する方が良さそうな気がします(公式に推奨されています1

Footnotes

  1. https://github.com/nodejs/corepack?tab=readme-ov-file#when-authoring-packages

@samunohito
Copy link
Member Author

corepack upで更新しなおしました

@kakkokari-gtyih kakkokari-gtyih changed the base branch from develop to release/2024.5.0 May 10, 2024 07:15
@syuilo
Copy link
Member

syuilo commented May 10, 2024

マージ先はdevelopの方が良くないかしら?

@syuilo
Copy link
Member

syuilo commented May 10, 2024

「Check Misskey JS autogen / generate-misskey-js (pull_request_target) がコケる」はリリース云々関係なく修正されるべきことなため
(もし何らかの理由でリリースが中止になったらこの変更も失われる)

@tamaina
Copy link
Member

tamaina commented May 10, 2024

releaseブランチに対して行われた変更は正式リリース段階でdevelopにマージされるのでその心配はいらない

@acid-chicken
Copy link
Member

releaseブランチに対して行われた変更は正式リリース段階でdevelopにマージされるのでその心配はいらない

develop が開発における HEAD になるのを維持したいという話なので心配とかではない
(release はリベースしてほしい)

@github-actions github-actions bot deleted the branch misskey-dev:release/2024.5.0 May 31, 2024 12:24
@github-actions github-actions bot closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Misskey JS autogen / generate-misskey-js (pull_request_target) がコケる
5 participants