New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Vue3 #6587
Merged
Migrate to Vue3 #6587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Vue2をVue3に移行。
それに合わせて内部の大幅なリファクタリングも行っています。
将来的には全てのコンポーネントをComposition APIを利用したものに移行したいが、このPRでは基本的にやらない
Tasks
beforeDestroy
destroyed
-->beforeUnmount
unmounted
vue-router
history
option to replacemode
- https://next.router.vuejs.org/guide/migration/#new-history-option-to-replace-mode*
(star or catch all) routes - https://next.router.vuejs.org/guide/migration/#removed-star-or-catch-all-routesscrollBehavior
changes - https://next.router.vuejs.org/guide/migration/#scrollbehavior-changesThirdparty library status
portal-vue - Provide version that's Vue 3 compatible LinusBorg/portal-vue#300v-animate-css - https://github.com/jofftiquez/v-animate-cssResolve #2945
Resolve #5834
Resolve #6387
Resolve #6392
Resolve #6133
Resolve #6090
Resolve #6579
Resolve #6560
Close #6666
Close #5831
Close #6425
Fix #6569