-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: /proxyをFileServerServiceに統合し、/proxyのurlで/filesが指定されていた場合は直接ファイルを解決するようにする #9709
Conversation
p1.a9z.devで動作中 |
コンフリクト解消が面倒になったのでclose |
Codecov Report
@@ Coverage Diff @@
## develop #9709 +/- ##
===========================================
- Coverage 22.54% 22.53% -0.02%
===========================================
Files 736 735 -1
Lines 68817 68906 +89
Branches 2021 2022 +1
===========================================
+ Hits 15514 15527 +13
- Misses 53303 53379 +76
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
とりあえずpathベースにしてみた (あとsharpのストリームはtoBufferをawaitせずにsharp.Sharpを吸い取るようにした) |
streamを処理し切る前にcleanupしてしまうのでダメですね |
ストリームエンドでcleanupするのもダメっぽくて結局toBufferを待つ実装に戻した |
This reverts commit 636f919.
これは偽だったのでストリーム返信に戻した |
🙏🏻 |
What
Why
Related to #9695