Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9710 ? #9712

Merged
merged 6 commits into from
Jan 24, 2023
Merged

Fix #9710 ? #9712

merged 6 commits into from
Jan 24, 2023

Conversation

tamaina
Copy link
Member

@tamaina tamaina commented Jan 24, 2023 •
edited

#9710 ?

What

Why

@tamaina tamaina marked this pull request as draft January 24, 2023 04:48
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jan 24, 2023
@tamaina tamaina marked this pull request as ready for review January 24, 2023 05:01
@tamaina tamaina requested a review from syuilo January 24, 2023 05:01
@tamaina
Copy link
Member Author

tamaina commented Jan 24, 2023

downloadUrlはfetchであってほしい（#9453 のため）

@tamaina
Copy link
Member Author

tamaina commented Jan 24, 2023

bodyの消費問題って多分

WARN 4 [queue deliver] failed(TimeoutError: Promise timed out after 60000 milliseconds) id=962351 attempts=1/12 age=3m to=https://misskey.cf/inbox

なんだろうけど…あれつまりこれではなおらない？

@syuilo
Copy link
Member

syuilo commented Jan 24, 2023

あれつまりこれではなおらない？

というと？

@tamaina
Copy link
Member Author

tamaina commented Jan 24, 2023

というと？

このタイムアウトエラーがdeliverが重たいという現象の尻尾だと思っており、それが治っていない

@syuilo
Copy link
Member

syuilo commented Jan 24, 2023

治っていない

えー謎

@syuilo
Copy link
Member

syuilo commented Jan 24, 2023

解決しなさそうならgot試すしかないか

@tamaina
Copy link
Member Author

tamaina commented Jan 24, 2023

以前はnode-fetchでうまくいっていたのだからnode-fetchに戻すのが安牌では

@tamaina
Copy link
Member Author

tamaina commented Jan 24, 2023

deliverJobConcurrencyを減らしたらなんか割と大人しくなった

@tamaina
Copy link
Member Author

tamaina commented Jan 24, 2023

maxSocketsはdeliverJobConcurrencyだったのをdeliverJobConcurrency / clusterLimitにする処理を入れてみた

@tamaina
Copy link
Member Author

tamaina commented Jan 24, 2023

一旦マージしてみ感がある

@syuilo syuilo merged commit 6589e8a into develop Jan 24, 2023
@syuilo syuilo deleted the use-request branch January 24, 2023 06:54
@syuilo
Copy link
Member

syuilo commented Jan 24, 2023

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syuilo syuilo syuilo left review comments

Assignees
No one assigned
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tamaina @syuilo