Make require work #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add travis.yml
|
mister-ben
reviewed
Dec 14, 2017
| @@ -55,7 +56,7 @@ class Flvjs extends Html5 { | |||
| */ | |||
| Flvjs.isSupported = function() { | |||
|
|
|||
| return window.flvjs && window.flvjs.isSupported(); | |||
There was a problem hiding this comment.
We don't need to check for flvjs if we're importing it.
mister-ben
requested changes
Dec 14, 2017
There was a problem hiding this comment.
Thanks for the contribution! I think it's reasonable to import flv.js, although it's a major change. Could you update the docs to reflect that flv.js does not need to be separately included?
Also this will need a rebase on master for the fix I just pushed, sorry about that.
Add default empty objects for mediaDataSource and config (mister-ben#10)
…nto make_require_work
|
maybe, making import flv.js or not to configurable is more flexible, like the option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8