Skip to content

Commit

Permalink
Disable implicit suffix rules in submakefiles (#1902)
Browse files Browse the repository at this point in the history
I believe this was causing issues, e.g.,
[here](https://github.com/mit-plv/fiat-crypto/actions/runs/9023963682/job/24799935044?pr=1898#step:5:39)
when uploaded artifacts failed to preserve relative timestamps on .o
files vs output executables, and as a result invoked automatic [suffix
rules](https://www.gnu.org/software/make/manual/html_node/Suffix-Rules.html)
and failed.
  • Loading branch information
JasonGross committed May 10, 2024
1 parent d70c5eb commit 8360733
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Makefile.config
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
.SUFFIXES:

SKIP_BEDROCK2?=

VERBOSE?=
Expand Down
2 changes: 2 additions & 0 deletions Makefile.coq.local
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
.SUFFIXES:

PROFILE?=
OTHERFLAGS += -w -notation-overridden,-deprecated-hint-constr,-fragile-hint-constr,-native-compiler-disabled,-ambiguous-paths,-masking-absolute-name
ifneq ($(PROFILE),)
Expand Down
2 changes: 2 additions & 0 deletions Makefile.examples
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
# this makefile directly as long as the compiled binaries are lying
# around

.SUFFIXES:

include Makefile.config

CFLAGS?=
Expand Down
2 changes: 2 additions & 0 deletions Makefile.js-html
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
.SUFFIXES:

EXTRA_HTML_VERSION_INFO?=

.PHONY: fiat-html/version.js
Expand Down
2 changes: 2 additions & 0 deletions Makefile.standalone
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
# files on .v files, so that we can compile them by invoking this
# makefile directly even when Coq is not available

.SUFFIXES:

SELF_MAKEFILE_STANDALONE := $(lastword $(MAKEFILE_LIST))

include Makefile.config
Expand Down

0 comments on commit 8360733

Please sign in to comment.