Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition with unix process listing #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aelsabbahy
Copy link

When a system is aggressively launching new processes in parallel, it seems the processes() method returns an incomplete set of results.

I was seeing the issue in goss, here: goss-org/goss#267

I was able to resolve the issue by changing the directory lookup logic from:

for {
    fis, err := d.Readdir(10)
    if err == io.EOF {
        break
    }
}

To just simply:

fis, err := d.Readdir(-1)

I assume the size of /proc shouldn't cause concern with the -1 full read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants