Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the process cannot be found, it is better to return an error. #42

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

If the process cannot be found, it is better to return an error. #42

wants to merge 8 commits into from

Conversation

jgbooks
Copy link

@jgbooks jgbooks commented Jul 17, 2020

If the process cannot be found, it is better to return an error.

@cfergeau
Copy link

cfergeau commented Mar 8, 2021

This is an API breakage, dunno how bad the impact would be on go-ps users.
Windows and macOS would still return nil when the process is not found, so this change would make the API inconsistent on the various OSes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jgbooks @cfergeau @0xsubi