"Executable names truncated #15" fix for darwin #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with the linux and darwin executable names beeing truncated #15
This commit is only for the darwin side, the bug was due to
kinfo_proc->kp_proc.p_commonly beeing able to hold 16 Charsas it can be seen in sys/proc.h
p_comm[MAXCOMLEN + 1](MAXCOMLEN = 16)The commit is using libproc.h to get the execution path and using filepath.Base to receive only the executable name from the path
Credit: The function getExePathFromPid is from here comes with a great explanation