Macos processes #118
Open
Macos processes #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proxy_rs into macos-processes
not too much unsafe blocks
mhils
reviewed
Nov 2, 2023
mhils
reviewed
Nov 6, 2023
There was a problem hiding this comment.
This looks good now! Few smaller comments inline below.
The final thing I'm worried about here is memory leaks in the unsafe code. I suppose this is not super easy to test though. At the very least, can we maybe have some (#[ignore]d by default) test cases that call the unsafe methods (e.g. tif_data_for_executable) in a loop so that one can manually check for an increase in memory? Does that make sense? Smarter ideas are welcome as well of course, but I don't want to overcomplicate things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft to get first info from running processes:
there are a lot of steps before the png image (NSImage -> tif_representation -> bitmap_representation -> png_representation), maybe we can optimize that part