Update jest-dom, make TS aware #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See testing-library/jest-dom#517 for more info
| @@ -15,6 +15,7 @@ | |||
| "skipLibCheck": true, | |||
| "forceConsistentCasingInFileNames": true, | |||
| "resolveJsonModule": true, | |||
| "preserveWatchOutput": true | |||
| "preserveWatchOutput": true, | |||
| "types": ["node", "jest", "@testing-library/jest-dom"] | |||
There was a problem hiding this comment.
@testing-library/jest-dom adds more matchers to jest's expect(...); for example, expect(element).toBeInTheDocument(). In v6, the mechanism that informs typescript about the new matchers changed.
See testing-library/jest-dom#517 for a little more info.
ChristopherChudzicki
added
the
Needs Review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
=======================================
Coverage 75.02% 75.02%
=======================================
Files 248 248
Lines 11318 11318
Branches 1963 1963
=======================================
Hits 8491 8491
Misses 2653 2653
Partials 174 174 ☔ View full report in Codecov by Sentry. |
ChristopherChudzicki
temporarily deployed
to
github-pages
GitHub Actions
Inactive
shanbady
approved these changes
Mar 20, 2024
shanbady
added
Waiting on author
and removed
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See testing-library/jest-dom#517 for more info
What are the relevant tickets?
Closes #353
Description (What does it do?)
This PR updates jest and @testing-library/jest-dom.
How can this be tested?
Tests and CI should pass.