Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online-924 Dependabot Updates #1091

Closed
wants to merge 6 commits into from
Closed

Conversation

asadali145
Copy link
Contributor

@asadali145 asadali145 commented Oct 5, 2022

Pre-Flight checklist

  • Testing
    • Code is tested
    • Changes have been manually tested

What are the relevant tickets?

Fixes #924

What's this PR do?

Updates dependencies to resolve dependabot alerts.

How should this be manually tested?

Not sure how we should test this as there is no direct usage of these packages. What I did and can think of is:

  • All the tests are passing.
  • Check that everything works fine on the frontend web and refine the dashboard.

@odlbot odlbot temporarily deployed to mitxonline-ci-pr-1091 October 5, 2022 07:10 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #1091 (5fc9ff5) into main (fad270f) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 5fc9ff5 differs from pull request most recent head 11c75ff. Consider uploading reports for the commit 11c75ff to get more accurate results

@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
- Coverage   85.21%   85.18%   -0.03%     
==========================================
  Files         287      287              
  Lines       10974    10974              
  Branches      722      722              
==========================================
- Hits         9351     9348       -3     
- Misses       1415     1418       +3     
  Partials      208      208              
Impacted Files Coverage Δ
ecommerce/models.py 88.79% <0.00%> (-0.59%) ⬇️
ecommerce/views/v0/__init__.py 90.08% <0.00%> (-0.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@odlbot odlbot temporarily deployed to mitxonline-ci-pr-1091 October 5, 2022 07:26 Inactive
@odlbot odlbot temporarily deployed to mitxonline-ci-pr-1091 October 5, 2022 07:42 Inactive
@odlbot odlbot temporarily deployed to mitxonline-ci-pr-1091 October 5, 2022 09:21 Inactive
@odlbot odlbot temporarily deployed to mitxonline-ci-pr-1091 October 5, 2022 09:28 Inactive
@odlbot odlbot temporarily deployed to mitxonline-ci-pr-1091 October 5, 2022 09:38 Inactive
@arslanashraf7 arslanashraf7 self-assigned this Oct 18, 2022
@asadali145
Copy link
Contributor Author

Removed Needs Review for this. PRs are open by the dependabot.

@pdpinch
Copy link
Member

pdpinch commented Jan 11, 2023

@asadali145 what should we do with this PR?

@arslanashraf7
Copy link
Contributor

My thoughts are that we should close this since we merged #1201 which upgraded this dependency.

@asadali145
Copy link
Contributor Author

Yeah, We can close this one and work on reviewing the dependabot PRs for the version updates.

@asadali145 asadali145 closed this Jan 11, 2023
@asadali145 asadali145 deleted the asad/924-dependabot-updates branch March 17, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot updates
5 participants