Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable webpacker stylesheet errors in production #204

Merged
merged 1 commit into from Aug 18, 2021
Merged

Conversation

rbclark
Copy link
Contributor

@rbclark rbclark commented Aug 17, 2021

Webpacker has a nasty habit of not compiling css files for components and then causing an error in production when they are missing.
rails/webpacker#2342
rails/webpacker#2059 (comment)
This adds an override which causes no errors in production but still allows us to leave the stylesheet_pack_tag for when it is needed.

@rbclark rbclark requested review from Bialogs and jkufro August 17, 2021 22:45
@rbclark rbclark temporarily deployed to vulcan-fixproderror-8zr9vnqjis August 17, 2021 22:48 Inactive
@rbclark rbclark temporarily deployed to vulcan-fixproderror-8zr9vnqjis August 17, 2021 22:49 Inactive
@rbclark rbclark changed the title Disable webpacker stylesheet errors in production WIP: Disable webpacker stylesheet errors in production Aug 17, 2021
Webpacker has a nasty habit of not compiling css files for components and then causing an error in production when they are missing.
rails/webpacker#2342
rails/webpacker#2059 (comment)

Unfortunately using extract_css: true all the time apparently comes with some performance impacts, however the tradeoff is the application actually works correctly in development mode.
@rbclark rbclark temporarily deployed to vulcan-fixproderror-8zr9vnqjis August 18, 2021 02:57 Inactive
@rbclark rbclark changed the title WIP: Disable webpacker stylesheet errors in production Disable webpacker stylesheet errors in production Aug 18, 2021
@rbclark rbclark merged commit 4e2cf40 into master Aug 18, 2021
@rbclark rbclark deleted the fixProdError branch August 18, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant