Skip to content

Commit

Permalink
ci(pre-commit): Migrate from qmlformat to qml_formatter
Browse files Browse the repository at this point in the history
Although `qml_formatter` is much less mature, we can at least pin a
specific version via pre-commit. This is especially important since
`qmlformat` seems to change its formatting rules on every version bump,
so version incompatibilities between local computer and CI happen very
often.
  • Loading branch information
Holzhaus committed Sep 29, 2022
1 parent 52ed7ee commit d276d65
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,10 @@ repos:
hooks:
- id: prettier
types: [yaml]
- repo: https://github.com/Holzhaus/qml_formatter.git
rev: ee56e6adb31499f9003bd3419078c42ff6b204ed
hooks:
- id: qml_formatter
- repo: local
hooks:
- id: qsscheck
Expand All @@ -138,13 +142,6 @@ repos:
language: python
types: [text]
files: ^CHANGELOG.md$
- id: qmlformat
name: qmlformat
entry: tools/qmlformat.py
pass_filenames: true
language: system
types: [text]
files: ^.*\.qml$
- id: qmllint
name: qmllint
entry: qmllint
Expand Down

0 comments on commit d276d65

Please sign in to comment.