refactor: remove usage of _.forEach

mjeanroy · Mar 9, 2024 · 36882d2 · 36882d2
1 parent 4b5ee3c
commit 36882d2
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/src/format-path.js b/src/format-path.js
@@ -33,7 +33,7 @@ import _ from 'lodash';
 export function formatPath(paths) {
   let str = '';
 
-  _.forEach(paths, (p) => {
+  paths.forEach((p) => {
     if (_.isNumber(p)) {
       str += `[${p}]`;
     } else if (!str) {

diff --git a/src/license-plugin-option.js b/src/license-plugin-option.js
@@ -140,7 +140,7 @@ function validateOptions(options) {
 
   const messages = [];
 
-  _.forEach(errors, (e) => {
+  errors.forEach((e) => {
     if (e.type === 'object.allowUnknown') {
       warn(`Unknown property: "${formatPath(e.path)}", allowed options are: ${_.keys(SCHEMA).join(', ')}.`);
     } else {

diff --git a/src/license-plugin.js b/src/license-plugin.js
@@ -220,7 +220,7 @@ class LicensePlugin {
     }
 
     // Update the cache
-    _.forEach(scannedDirs, (scannedDir) => {
+    scannedDirs.forEach((scannedDir) => {
       this._cache[scannedDir] = pkg;
     });
   }
@@ -234,7 +234,7 @@ class LicensePlugin {
   scanDependencies(dependencies) {
     this.debug(`Scanning: ${dependencies}`);
 
-    _.forEach(dependencies, (dependency) => {
+    dependencies.forEach((dependency) => {
       this.scanDependency(dependency);
     });
   }
@@ -455,7 +455,7 @@ class LicensePlugin {
    * @return {void}
    */
   _scanLicenseViolations(outputDependencies, allow) {
-    _.forEach(outputDependencies, (dependency) => {
+    outputDependencies.forEach((dependency) => {
       this._scanLicenseViolation(dependency, allow);
     });
   }
@@ -541,7 +541,7 @@ class LicensePlugin {
    * @return {void}
    */
   _exportThirdParties(outputDependencies, outputs) {
-    _.forEach(_.castArray(outputs), (output) => {
+    _.castArray(outputs).forEach((output) => {
       this._exportThirdPartiesToOutput(outputDependencies, output);
     });
   }

diff --git a/src/person.js b/src/person.js
@@ -57,7 +57,7 @@ export class Person {
         }
       }
 
-      _.forEach(['name', 'email', 'url'], (prop) => {
+      ['name', 'email', 'url'].forEach((prop) => {
         if (_.has(o, prop)) {
           o[prop] = _.trim(o[prop]);
         }

diff --git a/src/schema-validator.js b/src/schema-validator.js
@@ -68,7 +68,8 @@ function doItemValidation(value, schema, path) {
 function validateObject(obj, schema, current) {
   const errors = [];
 
-  _.forEach(obj, (value, k) => {
+  Object.keys(obj).forEach((k) => {
+    const value = obj[k];
     if (_.isNil(value)) {
       return;
     }