refactor: remove usage of _.chain

mjeanroy · Mar 9, 2024 · 8f98129 · 8f98129
1 parent f98d613
commit 8f98129
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 32 deletions.
diff --git a/src/dependency.js b/src/dependency.js
@@ -60,10 +60,7 @@ export class Dependency {
     if (!this.license && pkg.licenses) {
       // Map it to a valid license field.
       // See: https://docs.npmjs.com/files/package.json#license
-      this.license = `(${_.chain(pkg.licenses)
-          .map((license) => license.type || license)
-          .join(' OR ')
-          .value()})`;
+      this.license = `(${pkg.licenses.map((license) => license.type || license).join(' OR ')})`;
     }
   }
 
@@ -98,13 +95,9 @@ export class Dependency {
 
     if (this.contributors.length > 0) {
       lines.push(`Contributors:`);
-
-      const allContributors = _.chain(this.contributors)
-          .map((contributor) => contributor.text())
-          .map((line) => `  ${line}`)
-          .value();
-
-      lines.push(...allContributors);
+      lines.push(
+          ...this.contributors.map((contributor) => `  ${contributor.text()}`),
+      );
     }
 
     if (this.licenseText) {

diff --git a/src/index.js b/src/index.js
@@ -22,7 +22,6 @@
  * SOFTWARE.
  */
 
-import _ from 'lodash';
 import {licensePlugin} from './license-plugin.js';
 
 /**
@@ -51,13 +50,19 @@ export default function rollupPluginLicense(options = {}) {
      * @return {void}
      */
     renderChunk(code, chunk, outputOptions = {}) {
+      const dependencies = [];
+
+      if (chunk.modules) {
+        Object.keys(chunk.modules).forEach((id) => {
+          const mod = chunk.modules[id];
+          if (mod && !mod.isAsset && mod.renderedLength > 0) {
+            dependencies.push(id);
+          }
+        });
+      }
+
       plugin.scanDependencies(
-          _.chain(chunk.modules)
-              .toPairs()
-              .reject((mod) => mod[1].isAsset)
-              .filter((mod) => mod[1].renderedLength > 0)
-              .map((mod) => mod[0])
-              .value(),
+          dependencies,
       );
 
       return plugin.prependBanner(code, outputOptions.sourcemap !== false);

diff --git a/src/license-plugin.js b/src/license-plugin.js
@@ -307,10 +307,9 @@ class LicensePlugin {
     }
 
     const includePrivate = thirdParty.includePrivate || false;
-    const outputDependencies = _.chain(this._dependencies)
-        .values()
-        .filter((dependency) => includePrivate || !dependency.private)
-        .value();
+    const outputDependencies = _.values(this._dependencies).filter((dependency) => (
+      includePrivate || !dependency.private
+    ));
 
     if (_.isFunction(thirdParty)) {
       thirdParty(outputDependencies);

diff --git a/src/schema-validator.js b/src/schema-validator.js
@@ -48,12 +48,18 @@ function doItemValidation(value, schema, path) {
     ];
   }
 
-  // Run "sub-validators"
-  return _.chain(matchedValidators)
-      .filter((validator) => validator.schema)
-      .map((validator) => validate(value, validator.schema, path))
-      .flatten()
-      .value();
+  const outputs = [];
+
+  for (let i = 0; i < matchedValidators.length; ++i) {
+    const validator = matchedValidators[i];
+    if (validator.schema) {
+      outputs.push(
+          ...validate(value, validator.schema, path),
+      );
+    }
+  }
+
+  return outputs;
 }
 
 /**
@@ -125,10 +131,15 @@ function validateArrayItem(item, idx, schema, current) {
  * @return {Array<Object>} Found errors.
  */
 function validateArray(array, schema, current) {
-  return _.chain(array)
-      .map((item, idx) => validateArrayItem(item, idx, schema, current))
-      .flatten()
-      .value();
+  const outputs = [];
+
+  for (let idx = 0; idx < array.length; ++idx) {
+    outputs.push(
+        ...validateArrayItem(array[idx], idx, schema, current),
+    );
+  }
+
+  return outputs;
 }
 
 /**