Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude tree shaken modules from dependencies to scan #384

Merged
merged 1 commit into from Jun 26, 2019
Merged

fix: exclude tree shaken modules from dependencies to scan #384

merged 1 commit into from Jun 26, 2019

Conversation

mjeanroy
Copy link
Owner

Fix #380

lukastaegert
lukastaegert approved these changes Jun 11, 2019
View reviewed changes
src/index-rollup-stable.js Show resolved Hide resolved
test/index-rollup-stable.spec.js Show resolved Hide resolved
@mjeanroy mjeanroy force-pushed the fix-exclude-tree-shaken-dependencies branch from e750003 to c62af9c Compare June 11, 2019 11:56
@lukastaegert
Copy link
Contributor

rollup/rollup#2940 will make sure that renderedLength === 0 actually does coincide with a module being completely tree-shaken.

@mjeanroy mjeanroy merged commit 0d3b163 into master Jun 26, 2019
@mjeanroy mjeanroy deleted the fix-exclude-tree-shaken-dependencies branch June 26, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: Use tree-shaking information when generating third party dependencies
2 participants
@mjeanroy @lukastaegert