Remove disabled condition from :active matching

We are changing this behavior because other browsers don't have disabled conditioning for :active and because it will become more consistent with other pseudo classes: whatwg/html#6635 (comment) Fixed: 1287171 Change-Id: Idab2abbbc94cc73fac70e34ef391c5d63518d569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3453424 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#970008} NOKEYCHECK=True GitOrigin-RevId: ed8595a55c008ac96404f2d95408f59c9a3833b6
mjfroman · Feb 11, 2022 · 59bf7f7 · 59bf7f7
1 parent f157cce
commit 59bf7f7
Show file tree

Hide file tree

Showing 4 changed files with 87 additions and 48 deletions.
diff --git a/blink/renderer/core/dom/document.cc b/blink/renderer/core/dom/document.cc
@@ -7283,8 +7283,7 @@ void Document::UpdateActiveState(bool is_active,
     SetActiveElement(nullptr);
   } else {
     Element* new_active_element = inner_element_in_document;
-    if (!old_active_element && new_active_element &&
-        !new_active_element->IsDisabledFormControl() && is_active) {
+    if (!old_active_element && new_active_element && is_active) {
       // We are setting the :active chain and freezing it. If future moves
       // happen, they will need to reference this chain.
       for (Element* element = new_active_element; element;

diff --git a/blink/web_tests/external/wpt/html/semantics/selectors/pseudo-classes/active-disabled.html b/blink/web_tests/external/wpt/html/semantics/selectors/pseudo-classes/active-disabled.html
@@ -0,0 +1,86 @@
+<!DOCTYPE html>
+<link rel=author href="mailto:jarhar@chromium.org">
+<link rel=help href="https://github.com/whatwg/html/pull/7465">
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="/resources/testdriver.js"></script>
+<script src="/resources/testdriver-actions.js"></script>
+<script src="/resources/testdriver-vendor.js"></script>
+
+<label id=buttonlabel for=disabledbutton>label for disabled button</label>
+<button id=disabledbutton disabled>disabled</button>
+
+<button id=buttonparent disabled>
+  <div id=buttonchild>child of disabled</div>
+</button>
+
+<input id=disabledinput disabled>
+
+<textarea id=disabledtextarea disabled>disabled textarea</textarea>
+
+<script>
+promise_test(async () => {
+  await (new test_driver.Actions()
+    .pointerMove(2, 2, {origin: disabledbutton})
+    .pointerDown())
+    .send();
+
+  assert_true(disabledbutton.matches(':active'));
+
+  await (new test_driver.Actions()
+    .pointerUp())
+    .send();
+}, 'Clicking on a disabled button should make it get the :active selector.');
+
+promise_test(async () => {
+  await (new test_driver.Actions()
+    .pointerMove(2, 2, {origin: buttonlabel})
+    .pointerDown())
+    .send();
+
+  assert_true(disabledbutton.matches(':active'));
+
+  await (new test_driver.Actions()
+    .pointerUp())
+    .send();
+}, 'Clicking the label for a disabled button should make the button get the :active selector.');
+
+promise_test(async () => {
+  await (new test_driver.Actions()
+    .pointerMove(2, 2, {origin: buttonchild})
+    .pointerDown())
+    .send();
+
+  assert_true(buttonparent.matches(':active'));
+
+  await (new test_driver.Actions()
+    .pointerUp())
+    .send();
+}, 'Clicking on a child of a disabled button should make the button get the :active selector.');
+
+promise_test(async () => {
+  await (new test_driver.Actions()
+    .pointerMove(2, 2, {origin: disabledinput})
+    .pointerDown())
+    .send();
+
+  assert_true(disabledinput.matches(':active'));
+
+  await (new test_driver.Actions()
+    .pointerUp())
+    .send();
+}, 'Clicking on a disabled input should make it get the :active selector.');
+
+promise_test(async () => {
+  await (new test_driver.Actions()
+    .pointerMove(2, 2, {origin: disabledtextarea})
+    .pointerDown())
+    .send();
+
+  assert_true(disabledtextarea.matches(':active'));
+
+  await (new test_driver.Actions()
+    .pointerUp())
+    .send();
+}, 'Clicking on a disabled textarea should make it get the :active selector.');
+</script>
diff --git a/blink/web_tests/fast/css/disabled-form-control-elements-should-not-be-active-expected.txt b/blink/web_tests/fast/css/disabled-form-control-elements-should-not-be-active-expected.txt
diff --git a/blink/web_tests/fast/css/disabled-form-control-elements-should-not-be-active.html b/blink/web_tests/fast/css/disabled-form-control-elements-should-not-be-active.html