-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatibility with mkdocs 1.2. #295
Comments
To add to this issue, as mentioned in mkdocs/mkdocs#2448 this import error also occurs when running |
The import just isn't needed whatsoever. But indeed currently it's done always. |
I see, it's only for type hints. In that case, one could add the following also: from typing import TYPE_CHECKING
if TYPE_CHECKING:
from livereload import Server
def on_serve(self, server: "Server", builder: Callable, **kwargs): so that livereload would be a dependency for development only. |
Sorry, looks like for now a workaround will have to be used, until a new release with the fix can be made.
|
The release with the fix is now out. @themightychris @jaceklaskowski @plannigan @deepcharles @lyz-code @Midnighter @coady @yi2020 |
Unless I'm doing something completely wrong the latest release of mkdocs-material-insiders
What's interesting is that the last line in the stack trace shows no connection to mkdocstrings (and am wondering how this change could change anything)? It clearly points at # necessary because of a bug in mkdocs:
# more information in:
# https://github.com/mkdocs/mkdocs/issues/1952))
builder = list(server.watcher._tasks.values())[0]["func"] I'm stuck and am begging for some help. Right after I posted it I found this. I should've noticed that it's mkdocs_macros_plugin to blame (which I do use along with mkdocs-material). HTH |
Describe the bug
The new released mkdocs 1.2 includes
livereload
, not as a dependency. Resulting in an import error:To Reproduce
Steps to reproduce the behavior:
pip install mkdocstrings
python -c 'import mkdocstrings.plugin'
Expected behavior
No error.
Information (please complete the following information):
mkdocstrings
version: 0.15.1The text was updated successfully, but these errors were encountered: