Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with MkDocs 1.2: livereload isn't guaranteed now #294

Merged
merged 1 commit into from Jun 9, 2021
Merged

Compatibility with MkDocs 1.2: livereload isn't guaranteed now #294

merged 1 commit into from Jun 9, 2021

Conversation

oprypin
Copy link
Member

@oprypin oprypin commented Jun 7, 2021 •
edited

MkDocs doesn't depend on 'livereload' library anymore, and neither should we, but we import it for the type annotation, which is now also wrong.

I also take this opportunity to drop compatibility with MkDocs 1.1.0 (without dropping 1.1.1)'

Fixes #295

@oprypin oprypin changed the base branch from cherry-picks-0-15-1 to master June 7, 2021 23:36
@oprypin
Compatibility with MkDocs 1.2: livereload isn't guaranteed now
ed91083 
MkDocs doesn't depend on 'livereload' library, and neither should we, but we import it for the type annotation, which is now also wrong

Also fix tests: `site_url` value is now required for MkDocs
@jmaupetit
Copy link

Thank you for this! 🙏 Looking for these changes to be merged and released to upgrade to mkdocs 1.2.

@oprypin oprypin mentioned this pull request Jun 8, 2021
Closed
@Lucartas Lucartas mentioned this pull request Jun 9, 2021
Closed
@pawamoy
Copy link
Member

pawamoy commented Jun 9, 2021

Hey @oprypin, thanks a lot for the quick fix (and sorry for the slow reactivity, I've been quite busy these last three days). I'll merge this and try to release 0.15.2 as soon as possible as this issue can be quite annoying.

@pawamoy pawamoy merged commit e8d6573 into master Jun 9, 2021
@pawamoy
Copy link
Member

pawamoy commented Jun 9, 2021

In fact I think we'll need to release 0.16 for this.

@oprypin oprypin deleted the nolive branch June 9, 2021 20:37
@oprypin
Copy link
Member Author

oprypin commented Jun 9, 2021

@pawamoy Well whatever it will be, if you can't comfortably work on this release, please just grant me access to PyPI. Or let me know if I can help otherwise.

@pawamoy
Copy link
Member

pawamoy commented Jun 9, 2021

I'll grant you access to PyPI (reducing the bus factor yay) 🙂
Feel free to push 0.15.2 with a usual changelog entry or a simplified one.
I'll prioritize (on my own end) updating docs for 0.16 during the next few days.

oprypin added a commit that referenced this pull request Jun 9, 2021
@oprypin
refactor: Compatibility with MkDocs 1.2: livereload isn't guaranteed now
36e8024 
MkDocs doesn't depend on 'livereload' library, and neither should we, but we import it for the type annotation, which is now also wrong.

Also fix tests: `site_url` value is now required for MkDocs.

PR #294: #294
@jmaupetit
Copy link

Thank you both @oprypin & @pawamoy ❤️

@fhightower fhightower mentioned this pull request Jun 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawamoy pawamoy pawamoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatibility with mkdocs 1.2.
3 participants
@oprypin @jmaupetit @pawamoy