Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C89 happy. #18

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

C89 happy. #18

wants to merge 12 commits into from

Conversation

ssrlive
Copy link
Contributor

@ssrlive ssrlive commented Dec 23, 2019

I have changed the code to fit C89 standard. Please review it. Hope you can merge it. Thanks.

@ssrlive
Copy link
Contributor Author

ssrlive commented Dec 23, 2019 •
edited

When I changed all malloc call to calloc call, the make command will pass successfully, but CMake will keep failed with Heap allocation referenced from stack should be tagged.

@ganesh-k13
Copy link
Contributor

Hi @ssrlive , I am facing same problem with gcc over clang, see #17,

@ssrlive ssrlive changed the title c89 happy. C89 happy. Jan 2, 2020
@ssrlive
Copy link
Contributor Author

ssrlive commented Feb 23, 2020

Hi @mkirchner, I hope you merge this changes. Thanks.

@mkirchner
Copy link
Owner

Hi @ssrlive, this is C99 compatible; what is the reason to downgrade to C89?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkirchner mkirchner Awaiting requested review from mkirchner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ssrlive @ganesh-k13 @mkirchner