-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Arabic translations to all countries #256
base: master
Are you sure you want to change the base?
Conversation
We now have two similar pull requests to add arabic translations, that's fantastic but I don't know which one to accept :/ Also, I see that some translations differ, for example the official name of New Caledonia: and in #262 we have Which one is correct? |
@mledoze |
Yes I also saw that difference. Could you please check the two pull requests and propose the one that should be merged? |
Ok cool, I will be working with @sombek to merge our changes, but I will change something I just noticed yesterday, Saudi Arabia's common name in "name": {
"native": {
"ara": {
"common": "..."
}
}
}, is not the same common one we use in the Arab world, we just call it Saudi. |
Hey @MrSltun |
I will close this pull request for now. Feel free to reopen it when you are ready. |
Hi @mledoze, I just updated my branch and added the Arabic translation again to countries.json, and regenerated the Thanks |
@MrSltun the PR is open again. |
What's the status of this? |
…abicTranslation
@claesjacobsson It is updated with master now |
@mledoze please review it and merge it if everything is good |
@mledoze Any chance of merging and releasing this soon? Thanks! |
@mledoze any updates on this ? |
any update? |
Few things worth mentioning: