Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Arabic translations to all countries #256

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MrSltun
Copy link

@MrSltun MrSltun commented Jan 6, 2018

Few things worth mentioning:

  • Followed the three-letter ISO 639-3 language code in adding Arabic.
  • Escaped all Arabic characters.

@mledoze
Copy link
Owner

mledoze commented Jan 23, 2018

@MrSltun @sombek

We now have two similar pull requests to add arabic translations, that's fantastic but I don't know which one to accept :/

Also, I see that some translations differ, for example the official name of New Caledonia:
in this pull request we have \u0643\u0627\u0644\u064A\u062F\u0648\u0646\u064A\u0627 \u0627\u0644\u062C\u062F\u064A\u062F\u0629

and in #262 we have \u0643\u0627\u0644\u064A\u062F\u0648\u0646\u064A\u0627\u0020\u0627\u0644\u062C\u062F\u064A\u062F\u0629

Which one is correct?

@sombek
Copy link

sombek commented Jan 24, 2018

@mledoze
The difference in the above example is just a space character \u0020.
I think both of them are okay.
If there are some differences we can check it out and choose the proper one.

@mledoze
Copy link
Owner

mledoze commented Jan 25, 2018

The difference in the above example is just a space character \u0020.

Yes I also saw that difference. Could you please check the two pull requests and propose the one that should be merged?

@MrSltun
Copy link
Author

MrSltun commented Jan 26, 2018

Ok cool, I will be working with @sombek to merge our changes, but I will change something I just noticed yesterday, Saudi Arabia's common name in

"name": {
    "native": {
        "ara": {
            "common": "..."
	}
    }
},

is not the same common one we use in the Arab world, we just call it Saudi.

@sombek
Copy link

sombek commented Feb 5, 2018

Hey @MrSltun
How are things going?

@mledoze
Copy link
Owner

mledoze commented Feb 8, 2018

@sombek @MrSltun

I will now release the version 2.0.0 of this project and will include these translations in another release, for example v2.1.0.

@mledoze mledoze added this to the Release v2.1.0 milestone Feb 8, 2018
@mledoze
Copy link
Owner

mledoze commented Apr 10, 2020

I will close this pull request for now. Feel free to reopen it when you are ready.

@mledoze mledoze closed this Apr 10, 2020
@MrSltun
Copy link
Author

MrSltun commented Apr 14, 2020

Hi @mledoze,

I just updated my branch and added the Arabic translation again to countries.json, and regenerated the dist files, but I don't seem to have the rights to reopen this pull request, can you please reopen it for me?

Thanks

@mledoze mledoze reopened this Jul 18, 2020
@mledoze
Copy link
Owner

mledoze commented Jul 18, 2020

@MrSltun the PR is open again.

@claesjacobsson
Copy link

What's the status of this?

@MrSltun
Copy link
Author

MrSltun commented Sep 28, 2021

@claesjacobsson It is updated with master now

@MrSltun
Copy link
Author

MrSltun commented Sep 28, 2021

@mledoze please review it and merge it if everything is good

@claesjacobsson
Copy link

claesjacobsson commented Oct 7, 2021

@mledoze Any chance of merging and releasing this soon? Thanks!

@guibranco
Copy link

@mledoze any updates on this ?

@yasseralsaidi
Copy link

any update?

@mledoze mledoze removed this from the Release v2.1.0 milestone Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants