-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cascade experiment id fk deletion in datasets table #11966
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Li <minghao_li@outlook.com>
Documentation preview for 53561b5 will be available when this CircleCI job More info
|
CONSTRAINT trace_info_pk PRIMARY KEY (request_id), | ||
PRIMARY KEY (request_id), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harupy can you double check if this is okay? Running tests/db/update_schemas.sh
is automatically removing the primary key constraint name in the mysql schema for the trace tables despite this PR not touching the trace models at all. It looks like mysql doesn't allow for primary key constraints to be named?
EDIT: on second look, all named primary key constraints are already unnamed in the mysql schema, so this is expected
@BenWilson2 resubmission of #11695 here, if you could take a look that would be great |
Signed-off-by: Michael Li <minghao_li@outlook.com>
#7 263.8 E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/t/tcl8.6/tcl8.6-dev_8.6.10+dfsg-1_amd64.deb Undetermined Error [IP: 185.125.190.36 80] https://github.com/mlflow/mlflow/actions/runs/9027441291/job/24806333059?pr=11966#step:10:1325 Not too sure how to address, error unrelated to the PR |
Hi @BenWilson2, any chance you could take a look at this PR this week? Hoping to avoid the same situation as last time where another DB migration gets merged prior to this. Thanks in advance! |
Looks like another migration was merged #12102 Please hold off on merging this PR, I'll try to get around to addressing this over the weekend |
馃洜 DevTools 馃洜
Install mlflow from this PR
Checkout with GitHub CLI
Related Issues/PRs
Resolve #10699
What changes are proposed in this pull request?
Apply cascading deletion to the
experiment_id
foreign key in the datasets table.Resubmission of #11695
How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
Fixes a bug where
mlflow gc
will fail attempting to permanently delete an experiment if existing datasets are associated with the experiment.What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/deployments
: MLflow Deployments client APIs, server, and third-party Deployments integrationsarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yes
should be selected for bug fixes, documentation updates, and other small changes.No
should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.What is a minor/patch release?
Bug fixes, doc updates and new features usually go into minor releases.
Bug fixes and doc updates usually go into patch releases.