Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Generate the Reads-sections dynamically from the OverrideCycles #20

Merged
merged 7 commits into from
May 22, 2024
Merged

feat: Generate the Reads-sections dynamically from the OverrideCycles #20

merged 7 commits into from
May 22, 2024

Conversation

simbig
Copy link
Contributor

@simbig simbig commented May 16, 2024

  • Added automated tests
  • Documented for all relevant versions
  • Updated the changelog

Breaking changes

  • Generate the Reads-Sections dynamically from the OverrideCycles-part of the Samples-Section for Illumina NovaSeq Sample Sheets (V2)
  • OverrideCycles on BclSample not nullable

spawnia
spawnia reviewed May 16, 2024
View reviewed changes
src/IlluminaSampleSheet/V2/BclConvert/BclConvertSection.php Outdated Show resolved Hide resolved
src/IlluminaSampleSheet/V2/BclConvert/BclConvertSection.php Outdated Show resolved Hide resolved
src/IlluminaSampleSheet/V2/BclConvert/BclConvertSection.php Outdated Show resolved Hide resolved
src/IlluminaSampleSheet/V2/BclConvert/BclConvertSection.php Show resolved Hide resolved
src/IlluminaSampleSheet/V2/BclConvert/BclConvertSection.php Show resolved Hide resolved
src/IlluminaSampleSheet/V2/BclConvert/CycleTypeWithCount.php Outdated Show resolved Hide resolved
src/IlluminaSampleSheet/V2/BclConvert/OverrideCycle.php Outdated Show resolved Hide resolved
src/IlluminaSampleSheet/V2/BclConvert/OverrideCycles.php Outdated Show resolved Hide resolved
src/IlluminaSampleSheet/V2/BclConvert/OverrideCycles.php Outdated Show resolved Hide resolved
src/IlluminaSampleSheet/V2/BclConvert/OverrideCycles.php Outdated Show resolved Hide resolved
simbig and others added 2 commits May 16, 2024 17:01
@simbig @spawnia
Apply suggestions from code review
672218c 
Co-authored-by: Benedikt Franke <benedikt.franke@mll.com>
fixes from review
c9ee25c
@simbig simbig requested a review from spawnia May 16, 2024 15:24
@simbig simbig requested a review from spawnia May 17, 2024 11:51
@simbig simbig merged commit ba87d16 into master May 22, 2024
33 checks passed
@simbig simbig deleted the generate-reads-section-from-override-cycles branch May 22, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spawnia spawnia spawnia approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simbig @spawnia