Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coordinate system logic to plate component #157

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

simbig
Copy link
Contributor

@simbig simbig commented Mar 31, 2022

No description provided.

@simbig simbig requested a review from mic-web April 4, 2022 07:24
src/Plate/utils.ts Outdated Show resolved Hide resolved
src/Plate/coordinate.ts Outdated Show resolved Hide resolved
src/Plate/coordinate.ts Outdated Show resolved Hide resolved
src/Plate/coordinate.ts Outdated Show resolved Hide resolved
@simbig simbig requested a review from mic-web April 7, 2022 09:27
@spawnia
Copy link
Member

spawnia commented Apr 7, 2022

This pull request should be squashed, and the new commit message should detail the breaking changes using the proper format to ensure it results in a major version bump.

@simbig
Copy link
Contributor Author

simbig commented Apr 7, 2022

This pull request should be squashed, and the new commit message should detail the breaking changes using the proper format to ensure it results in a major version bump.

Good hint!
With the exception of the Plate component, I've kept the API compatible with the current version.

I wonder if it's better to add more cleanups and delete previously used code and make a one breaking change in the next release, or if it's worth staying downward compatible, not making any breaking changes for now and just adding deprecation docs and warnings like the following.

export function Plate(props: PlateProps) {
  ....

  if (!props.coordinateSystem) {
    console.warn('Deprecated usage of Plate-component. Provide coordinateSystem!')
  }

  const coordinateSystem: CoordinateSystem = props.coordinateSystem ?? new CoordinateSystem96Well()
.....

@spawnia
Copy link
Member

spawnia commented Apr 7, 2022

Move fast and break things 😉 (and upgrade our applications proactively while you still know exactly what to do)

Simon Bigelmayr added 2 commits April 22, 2024 13:48
…plate_component

# Conflicts:
#	src/Plate/index.stories.tsx
#	src/Plate/index.tsx
#	src/Plate/utils.test.tsx
#	src/Plate/utils.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants