feat: global forms provider #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spawnia
reviewed
Dec 1, 2023
spawnia
reviewed
Dec 1, 2023
spawnia
requested changes
Dec 4, 2023
Comment on lines
+18
to
+20
| /** | ||
| * Returns a combined boolean of all submitSuccessful states | ||
| */ |
Comment on lines
+34
to
+42
| export function useGlobalForms() { | ||
| const { isSubmitting, reset, submit } = useContext(GlobalFormsContext); | ||
|
|
||
| return { | ||
| isSubmitting, | ||
| reset, | ||
| submit, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Why is this function necessary or useful? It seems to me like the indirection is not needed.
| import React, { useCallback, useContext, useMemo } from 'react'; | ||
|
|
||
| export type FormInfo = { name: string; order: number }; | ||
| type FormInfoMixed = string | FormInfo; |
There was a problem hiding this comment.
Suggested change
| type FormInfoMixed = string | FormInfo; | |
| type FormInfoObjectOrString = FormInfo | string; |
| return form; | ||
| } | ||
|
|
||
| export function useGlobalForm(form: FormInfoMixed) { |
There was a problem hiding this comment.
When would I use an explicit order?
| setSubmitSuccessful, | ||
| } = useContext(GlobalFormsContext); | ||
|
|
||
| const setResetCallbackWrapped = useCallback( |
There was a problem hiding this comment.
Suggested change
| const setResetCallbackWrapped = useCallback( | |
| const setResetCallbackMemoized = useCallback( |
It is not just wrapped in some arbitrary way.
| import { useGlobalForms, useGlobalForm } from './GlobalFormsContext'; | ||
| import { GlobalFormsProvider } from './GlobalFormsProvider'; | ||
|
|
||
| function createOptions() { |
There was a problem hiding this comment.
Options for what? An explicit return type might help
Comment on lines
+169
to
+171
| expect(submitFirst).toHaveBeenCalledTimes(1); | ||
| expect(submitError).toHaveBeenCalledTimes(1); | ||
| expect(submitLast).toHaveBeenCalledTimes(0); |
There was a problem hiding this comment.
I think this does not prove the order was correct, I think you can swap the numbers around and still pass this test.
| function findNextOrder( | ||
| callbacks: Record<string, CallbackWithOrder> | undefined, | ||
| ): number { | ||
| const orders = values(callbacks).map((callback) => callback.order); |
There was a problem hiding this comment.
Suggested change
| const orders = values(callbacks).map((callback) => callback.order); | |
| const orders = Object.values(callbacks).map((callback) => callback.order); |
|
|
||
| const submit: GlobalFormsContextType['submit'] = useCallback( | ||
| async (additionalCallback?: CallbackWithOrder) => { | ||
| keys(submitCallbacks).forEach((formName) => { |
There was a problem hiding this comment.
Suggested change
| keys(submitCallbacks).forEach((formName) => { | |
| Object.keys(submitCallbacks).forEach((formName) => { |
| keys(submitCallbacks).forEach((formName) => { | ||
| submitSuccessfulList.current[formName] = false; | ||
| }); | ||
| const callbacks = values(submitCallbacks); |
There was a problem hiding this comment.
Suggested change
| const callbacks = values(submitCallbacks); | |
| const callbacks = Object.values(submitCallbacks); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: global forms provider