Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Install-PhpExtensionPrerequisite in Enable-PhpExtension #78

Closed
wants to merge 1 commit into from

Conversation

shivammathur
Copy link
Contributor

@shivammathur shivammathur commented May 8, 2021

This change would ensure that the dependencies for imagick are present before enabling it.

Fixes shivammathur/setup-php#455

@mlocati
Copy link
Owner

mlocati commented May 10, 2021

That would require that every time an extension is enabled the dependencies are being installed, which is really sub-optimal 😉

A better solution is to expose Install-PhpExtensionPrerequisite (well, I actually renamed it as Install-PhpExtensionPrerequisites), so that you can call it manually if you fetch the PHP extensions in a different way than Install-PhpExtension.

@mlocati mlocati closed this May 10, 2021
@mlocati
Copy link
Owner

mlocati commented May 10, 2021

Superseded by #79

@shivammathur
Copy link
Contributor Author

@mlocati Good catch, I was just thinking from the CI point of view.

@shivammathur shivammathur deleted the add-deps-enable branch May 10, 2021 10:41
@mlocati
Copy link
Owner

mlocati commented May 10, 2021

@shivammathur I've just released version 1.25.0: you can call the Install-PhpExtensionPrerequisite command to install the dependencies of all the extensions (well, at the moment only imagick, but we can easily add support for other extensions if needed).

@shivammathur
Copy link
Contributor Author

shivammathur commented May 10, 2021

@mlocati

Here $Path should be $PhpPath.

$phpVersion = [PhpVersionInstalled]::FromPath($Path)

Also typo here

@mlocati
Copy link
Owner

mlocati commented May 10, 2021

@shivammathur Thanks! I've just published a new version with those fixes

@shivammathur
Copy link
Contributor Author

@mlocati Thanks for the quick fixes. It works now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install imagick on Windows with extension cache
2 participants