Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some new fancy config options #4658

Closed
wants to merge 1 commit into from

Conversation

HofiOne
Copy link

@HofiOne HofiOne commented Jan 19, 2024

  • Option enable_copy_code_button to add copy button to Code blocks
  • Option page_content_width to set the width of the inner content part of pages
  • Option sidebar:sticky to be able to stick the navigator left sidebar to the the top
  • Option masthead:sticky to be able to stick the navigator top bar to the the top
  • Option masthead:hide_navigator to be able to hide the navigator item of the top bar

At code level, added possibility to define separate width values to the left sidebar

Signed-off-by: Hofi hofione@gmail.com

@HofiOne HofiOne marked this pull request as draft January 19, 2024 19:31
@HofiOne HofiOne marked this pull request as ready for review January 19, 2024 22:24
@HofiOne HofiOne changed the title Added some new fancy config option Added some new fancy config options Jan 21, 2024
@HofiOne HofiOne marked this pull request as draft January 21, 2024 16:22
@HofiOne HofiOne force-pushed the enhancements branch 4 times, most recently from ecc3214 to ca452d0 Compare January 23, 2024 15:26
@HofiOne HofiOne marked this pull request as ready for review January 23, 2024 15:26
@HofiOne HofiOne marked this pull request as draft January 23, 2024 21:10
@HofiOne HofiOne force-pushed the enhancements branch 3 times, most recently from edc2502 to 2ffd993 Compare January 23, 2024 23:33
- Option `enable_copy_code_button` to add copy button to Code blocks
- Option `page_content_width` to set the width of the inner content part of pages
- Option `sidebar:sticky` to be able to stick the navigator left sidebar to the the top
- Option `masthead:sticky` to be able to stick the navigator top bar to the the top
- Option `masthead:hide_navigator` to be able to hide the navigator item of the top bar

At code level, added possibility to define separate width values to the left sidebar

Signed-off-by: Hofi <hofione@gmail.com>
@HofiOne HofiOne marked this pull request as ready for review January 24, 2024 00:00
@iBug
Copy link
Collaborator

iBug commented Apr 23, 2024

This could certainly be useful, but it's too large and a bit messy to review. If you split each feature into a separate PR, I'll look more favorably on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants