feat: use throw types for better error messages #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be really helpful |
|
@mmkal Hello, that would be great. Can your finish it? |
|
Nope. microsoft/TypeScript#40468 would have to go into typescript first. |
This was referenced Oct 21, 2022
mmkal
added a commit
to mmkal/expect-type
that referenced
this pull request
Oct 23, 2022
|
also if anyone is watching this issue, take a look at mmkal/expect-type#16 which manages to improve error messages to some extent without needing throw types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on microsoft/TypeScript#40468
Error messages before:
Error messages after:
