Warn in toJS docs about deep cloning partial observables
#3239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warn in `toJS` docs about deep cloning partial observables, to avoid issues with some properties being deep clones while others are not. Relates to mobxjs#2912
🦋 Changeset detectedLatest commit: c7fd2a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
urugator
reviewed
Jan 3, 2022
|
@bernardobelchior Thank you for the clarification. Would you like to add this information to Mobx docs too? https://mobx.js.org/api.html#tojs |
urugator
approved these changes
Jan 4, 2022
|
@kubk I wouldn't mind. Although we would have to merge the docs and this comment, since they overlap a bit. |
|
@bernardobelchior OK, feel free to create a separate PR to Mobx docs. Thank you. @urugator Is there a way to restart pipelines? |
|
@kubk Yes by closing and reopening the PR :D |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn in
toJSdocs about deep cloning partial observables, to avoid issues with some properties being deep clones while others are not.I have faced this issue while upgrading to MobX 6 and I believe it will save other people some headaches if it is clear that
toJShas this limitation.Relates to #2912