Fix #3582, AbortSignal leaks @types/node #3583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7161187 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kubk
approved these changes
Nov 23, 2022
mweststrate
reviewed
Jan 3, 2023
packages/mobx/src/api/when.ts
Outdated
| @@ -9,11 +9,19 @@ import { | |||
| allowStateChanges | |||
| } from "../internal" | |||
|
|
|||
| // https://github.com/mobxjs/mobx/issues/3582 | |||
| export interface GenericAbortSignal { | |||
There was a problem hiding this comment.
NIT: I don't think this type necessarily needs exporting?
mweststrate
approved these changes
Jan 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3582
Not sure if optimal, but I used the same solution as the one in
axiospackage:https://github.com/axios/axios/blob/d032edda08948f3f613ff34f32af49cad3aa74db/index.d.ts#L215-L220
axios/axios#4229
axios/axios#5021 (why most of the interface is optional)
Another apporach I found is forward declaration:
declare global { export interface AbortSignal {} }as eg in: https://github.com/aws/aws-sdk-js-v3/blob/826807a8e0435580cac0d209ca8199a6231a9f96/packages/types/src/serde.ts#L59-L70
Dunno if applicable.