Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.10] Dockerfile: update Alpine to 3.16 #3350

Closed
wants to merge 1 commit into from

Conversation

crazy-max
Copy link
Member

follow-up #3349

Update to Alpine 3.16 on 0.10 branch as we are still using Go 1.18 and there is a bug fixed in Go 1.19 that is not still backported to 1.18: moby/moby#44570 (comment)

More info about the clang issue with Alpine 3.17: golang/go#53000 (comment)

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

Does not sound right, will look into this.

=== CONT  TestIntegration/TestSecurityModeSysfs/worker=oci/secmode=insecure
    client_test.go:865: 
        	Error Trace:	client_test.go:865
        	            				run.go:88
        	            				run.go:202
        	Error:      	Received unexpected error:
        	            	process "mkdir /sys/fs/cgroup/cpuset/securitytest" did not complete successfully: exit code: 1
        	            	github.com/moby/buildkit/util/stack.Enable
        	            		/src/util/stack/stack.go:77
        	            	github.com/moby/buildkit/util/grpcerrors.FromGRPC
        	            		/src/util/grpcerrors/grpcerrors.go:188
        	            	github.com/moby/buildkit/util/grpcerrors.UnaryClientInterceptor
        	            		/src/util/grpcerrors/intercept.go:41
        	            	google.golang.org/grpc.(*ClientConn).Invoke
        	            		/src/vendor/google.golang.org/grpc/call.go:35
        	            	github.com/moby/buildkit/api/services/control.(*controlClient).Solve
        	            		/src/api/services/control/control.pb.go:1443
        	            	github.com/moby/buildkit/client.(*Client).solve.func2
        	            		/src/client/solve.go:208
        	            	golang.org/x/sync/errgroup.(*Group).Go.func1
        	            		/src/vendor/golang.org/x/sync/errgroup/errgroup.go:57
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1571
        	            	failed to solve
        	            	github.com/moby/buildkit/client.(*Client).solve.func2
        	            		/src/client/solve.go:221
        	            	golang.org/x/sync/errgroup.(*Group).Go.func1
        	            		/src/vendor/golang.org/x/sync/errgroup/errgroup.go:57
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1571
        	Test:       	TestIntegration/TestSecurityModeSysfs/worker=oci/secmode=insecure

@crazy-max
Copy link
Member Author

crazy-max commented Dec 2, 2022

With the current issues in integration tests I opened another PR to just align Alpine version for the Go image:

@crazy-max crazy-max closed this Dec 2, 2022
@crazy-max crazy-max deleted the 0.10_alpine-316 branch December 3, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants