Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: upgrade OpenTelemetry libraries to v1.19.0 / v0.45.0 (carry) #4356

Closed
wants to merge 5 commits into from
Closed

vendor: upgrade OpenTelemetry libraries to v1.19.0 / v0.45.0 (carry) #4356

wants to merge 5 commits into from

Conversation

crazy-max
Copy link
Member

milas and others added 4 commits October 20, 2023 12:00
@milas @crazy-max
vendor: upgrade OpenTelemetry libraries to v1.19.0 / v0.45.0
f5438c0 
Core OTel libs are now at v1.19.0, while contrib is at v0.45.0.
The protocol has also reached 1.0.0.

Note that Jaeger exporter is frozen at v1.17.0, which is the
last version it was supported by OpenTelemetry. BuildKit should
likely begin the process of deprecating it as well, since OTLP
is now the recommended solution (by Jaeger themselves), but that
is not handled here.

Co-authored-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
fix lint and update generated files
1f41b82 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
vendor: update google.golang.org/grpc to v1.58.3
0946624 
fixes security issue (CVE-2023-44487)

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
dockerfile: smoke tests for binaries
4527c75 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

crazy-max commented Oct 20, 2023 •
edited

@milas validate-docs does not look happy when running buildctl: https://github.com/moby/buildkit/actions/runs/6586246047/job/17894238978#step:4:265

 > [gen 6/6] RUN --mount=target=/context   --mount=target=.,type=tmpfs <<EOT (set -e...):
0.503 could not run command buildctl build --help: exit status 1

Added extra commit with smoke tests for the binaries and it seems to complain about otel updates: https://github.com/moby/buildkit/actions/runs/6586246066/job/17894247170#step:5:480

0.094 + buildctl --version
0.106 error: cannot merge resource due to conflicting Schema URL

Same for any integration tests: https://github.com/moby/buildkit/actions/runs/6586246066/job/17894326770?pr=4356#step:8:12727

@crazy-max crazy-max mentioned this pull request Oct 20, 2023
Merged
@crazy-max
otel: fix semconv
06f9b5f 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

crazy-max commented Oct 20, 2023 •
edited

Schema should be 1.19.0 but semconv is set to 1.17.0: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/instrumentation%2Fgoogle.golang.org%2Fgrpc%2Fotelgrpc%2Fv0.45.0/instrumentation/google.golang.org/grpc/otelgrpc/internal/parse.go#L21.

Release notes is lying: https://github.com/open-telemetry/opentelemetry-go-contrib/releases/tag/v1.20.0

Edit: Yep open-telemetry/opentelemetry-go#2341 (comment)

@crazy-max
Copy link
Member Author

Ok now found out go.opentelemetry.io/otel/sdk is using semconv 1.21.0 while any other otel modules are using semconv 1.17.0.

@crazy-max crazy-max mentioned this pull request Oct 20, 2023
Merged
@crazy-max crazy-max closed this Nov 2, 2023
@crazy-max crazy-max deleted the otel-1.19 branch November 2, 2023 08:44
@gerhard gerhard mentioned this pull request Nov 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crazy-max @milas