Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor containerd v0.0.0-20210721160646-ee27cde735e2 #42983

Closed
wants to merge 4 commits into from
Closed

vendor containerd v0.0.0-20210721160646-ee27cde735e2 #42983

wants to merge 4 commits into from

Conversation

crazy-max
Copy link
Member

test containerd update, relates to #42968

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@crazy-max crazy-max force-pushed the update-containerd branch 2 times, most recently from c79ee9a to 4021d54 Compare November 2, 2021 13:16
thaJeztah
thaJeztah reviewed Nov 2, 2021
View reviewed changes
vendor.conf Outdated
github.com/golang/groupcache 869f871628b6baa9cfbc11732cdf6546b17c1298
go.opencensus.io d835ff86be02193d324330acdb7d65546b05f814 # v0.22.3
cloud.google.com/go ceeb313ad77b789a7fa5287b36a1d127b69b7093 # v0.44.3
github.com/googleapis/gax-go bd5b16380fd03dc758d11cef74ba2e3bc8b0e8c2 # v2.0.5
google.golang.org/genproto 3f1135a288c9a07e340ae8ba4cc6c7065a3160e8

# containerd
github.com/containerd/containerd 72cec4be58a9eb6b2910f5d10f1c01ca47d231c0 # v1.5.5
github.com/containerd/containerd ee27cde735e2a27a5e1465116ac98593b78d0a6f # v0.0.0-20210721160646-ee27cde735e2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider updating to v1.6.0-beta.1 ? https://github.com/containerd/containerd/compare/ee27cde735e2a27a5e1465116ac98593b78d0a6f..v1.6.0-beta.1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's the idea, was just doing some tests in this PR to repro with only containerd from #42968.

vendor/github.com/containerd/containerd/go.mod Outdated
@@ -3,7 +3,7 @@ module github.com/containerd/containerd
go 1.16

require (
github.com/Microsoft/go-winio v0.4.17
github.com/Microsoft/go-winio v0.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't checked yet, but any other (indirect) dependency from containerd that needs updating?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we are already on 0.5.1:

moby/vendor.conf

Line 3 in 229bc1e

github.com/Microsoft/go-winio 6c24dfa01eb5906508a5ad06f4f6534a9be47456 # v0.5.1

crazy-max
crazy-max commented Nov 2, 2021
View reviewed changes
vendor.conf Outdated
Comment on lines 21 to 22
golang.org/x/net e18ecbb051101a46fc263334b127c89bc7bff7ea # v0.0.0-20210226172049-e18ecbb05110
golang.org/x/sys 63515b42dcdf9544f4e6a02fd7632793fde2f72d # v0.0.0-20210823070655-63515b42dcdf
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to show the pseudo ver with timestamp to sort out deps easily.

@crazy-max

This comment has been minimized.

Sign in to view
@crazy-max
Copy link
Member Author

crazy-max commented Nov 2, 2021 •
edited

Ok one step further and got the same issue as #42968:

containerd/containerd@v1.5.5...ee27cde

=== Failed
=== FAIL: amd64.integration.service TestCreateServiceSecretFileMode (13.75s)
    create_test.go:294: assertion failed: string "\x03\x00\x00\x00\x00\x00\x00\xc2Error grabbing logs: rpc error: code = Unknown desc = warning: incomplete log stream. some logs could not be retrieved for the following reasons: node lp2kkml7brjssub6vmo35qdfn is not available\n" does not contain "-rwxrwxrwx"

=== FAIL: amd64.integration.service TestCreateServiceConfigFileMode (13.19s)
    create_test.go:351: assertion failed: string "\x03\x00\x00\x00\x00\x00\x00\xc2Error grabbing logs: rpc error: code = Unknown desc = warning: incomplete log stream. some logs could not be retrieved for the following reasons: node brz1vd1n2zcqxwa7w8pz2tosb is not available\n" does not contain "-rwxrwxrwx"

=== Failed
=== FAIL: amd64.integration-cli TestDockerSwarmSuite/TestServiceLogs (13.84s)
    docker_cli_service_logs_test.go:49: assertion failed: error is not nil: exit status 1
    --- FAIL: TestDockerSwarmSuite/TestServiceLogs (13.84s)

=== FAIL: amd64.integration-cli TestDockerSwarmSuite/TestServiceLogsCompleteness (32.68s)
    docker_cli_service_logs_test.go:60: assertion failed: 
        Command:  /usr/local/cli/docker --host unix:///tmp/docker-integration/d3a2bf66ec2d7.sock service logs -t --raw TestServiceLogsCompleteness
        ExitCode: 1
        Error:    exit status 1
        Stdout:   
        Stderr:   error from daemon in stream: Error grabbing logs: rpc error: code = Unknown desc = warning: incomplete log stream. some logs could not be retrieved for the following reasons: node wac3j5srw6pdkw73tlfgdjsne is not available
        
        
        
        Failures:
        ExitCode was 1 expected 0
        Expected no error
    docker_cli_service_logs_test.go:85: timeout hit after 30s: first check never completed
    --- FAIL: TestDockerSwarmSuite/TestServiceLogsCompleteness (32.68s)

=== FAIL: amd64.integration-cli TestDockerSwarmSuite/TestServiceLogsDetails (33.77s)
    docker_cli_service_logs_test.go:60: assertion failed: 
        Command:  /usr/local/cli/docker --host unix:///tmp/docker-integration/dd7b6eadf6b00.sock service logs -t --raw TestServiceLogsDetails
        ExitCode: 1
        Error:    exit status 1
        Stdout:   
        Stderr:   error from daemon in stream: Error grabbing logs: rpc error: code = Unknown desc = warning: incomplete log stream. some logs could not be retrieved for the following reasons: node 3jepwpjygjkhtuq1hgcx2xjub is not available
        
        
        
        Failures:
        ExitCode was 1 expected 0
        Expected no error
    docker_cli_service_logs_test.go:375: timeout hit after 30s: Empty stdout
    --- FAIL: TestDockerSwarmSuite/TestServiceLogsDetails (33.77s)

=== FAIL: amd64.integration-cli TestDockerSwarmSuite/TestServiceLogsNoHangDeletedContainer (42.79s)
    docker_cli_service_logs_test.go:60: assertion failed: 
        Command:  /usr/local/cli/docker --host unix:///tmp/docker-integration/d18b05110d4ee.sock service logs -t --raw TestServiceLogsNoHangDeletedContainer
        ExitCode: 1
        Error:    exit status 1
        Stdout:   
        Stderr:   error from daemon in stream: Error grabbing logs: rpc error: code = Unknown desc = warning: incomplete log stream. some logs could not be retrieved for the following reasons: node j54x0lvxjd42fintexrop6irh is not available
        
        
        
        Failures:
        ExitCode was 1 expected 0
        Expected no error
    docker_cli_service_logs_test.go:324: timeout hit after 30s: Empty stdout
    --- FAIL: TestDockerSwarmSuite/TestServiceLogsNoHangDeletedContainer (42.79s)

=== FAIL: amd64.integration-cli TestDockerSwarmSuite/TestServiceLogsSince (32.74s)
    docker_cli_service_logs_test.go:60: assertion failed: 
        Command:  /usr/local/cli/docker --host unix:///tmp/docker-integration/db20d06c122c9.sock service logs -t --raw TestServiceLogsSince
        ExitCode: 1
        Error:    exit status 1
        Stdout:   
        Stderr:   error from daemon in stream: Error grabbing logs: rpc error: code = Unknown desc = warning: incomplete log stream. some logs could not be retrieved for the following reasons: node xymwzrl67c078xdc3aa6q4uv2 is not available
        
        
        
        Failures:
        ExitCode was 1 expected 0
        Expected no error
    docker_cli_service_logs_test.go:134: timeout hit after 30s: Empty stdout
    --- FAIL: TestDockerSwarmSuite/TestServiceLogsSince (32.74s)

=== FAIL: amd64.integration-cli TestDockerSwarmSuite/TestServiceLogsTTY (42.97s)
    docker_cli_service_logs_test.go:290: timeout hit after 30s: output, "Error grabbing logs: rpc error: code = Unknown desc = warning: incomplete log stream. some logs could not be retrieved for the following reasons: node r6rd6loq925wiuqwtp0wdzjk8 disconnected unexpectedly\n"
    docker_cli_service_logs_test.go:60: assertion failed: 
        Command:  /usr/local/cli/docker --host unix:///tmp/docker-integration/d4ec6c832fd25.sock service logs -t --raw TestServiceLogsTTY
        ExitCode: 1
        Error:    exit status 1
        Stdout:   
        Stderr:   Cannot connect to the Docker daemon at unix:///tmp/docker-integration/d4ec6c832fd25.sock. Is the docker daemon running?
        
        
        Failures:
        ExitCode was 1 expected 0
        Expected no error
    --- FAIL: TestDockerSwarmSuite/TestServiceLogsTTY (42.97s)

=== FAIL: amd64.integration-cli TestDockerSwarmSuite/TestServiceLogsTail (42.90s)
    docker_cli_service_logs_test.go:60: assertion failed: 
        Command:  /usr/local/cli/docker --host unix:///tmp/docker-integration/dfd445362bb26.sock service logs -t --raw TestServiceLogsTail
        ExitCode: 1
        Error:    exit status 1
        Stdout:   
        Stderr:   error from daemon in stream: Error grabbing logs: rpc error: code = Unknown desc = warning: incomplete log stream. some logs could not be retrieved for the following reasons: node 69bm7xwms9o6ps64z43bvbc8j is not available
        
        
        
        Failures:
        ExitCode was 1 expected 0
        Expected no error
    docker_cli_service_logs_test.go:111: timeout hit after 30s: Empty stdout
    --- FAIL: TestDockerSwarmSuite/TestServiceLogsTail (42.90s)

=== FAIL: amd64.integration-cli TestDockerSwarmSuite/TestServiceLogsTaskLogs (43.30s)
    docker_cli_service_logs_test.go:60: assertion failed: 
        Command:  /usr/local/cli/docker --host unix:///tmp/docker-integration/dbb47cc9e7477.sock service logs -t --raw TestServicelogsTaskLogs
        ExitCode: 1
        Error:    exit status 1
        Stdout:   
        Stderr:   error from daemon in stream: Error grabbing logs: rpc error: code = Unknown desc = warning: incomplete log stream. some logs could not be retrieved for the following reasons: node aw6nfv8741fzv34n04666trwv is not available
        
        
        
        Failures:
        ExitCode was 1 expected 0
        Expected no error
    docker_cli_service_logs_test.go:236: timeout hit after 30s: Empty stdout
    --- FAIL: TestDockerSwarmSuite/TestServiceLogsTaskLogs (43.30s)

=== FAIL: amd64.integration-cli TestDockerSwarmSuite (1857.50s)

@tonistiigi
Copy link
Member

cc @AkihiroSuda , possible regression in 1.6

@crazy-max
vendor containerd v0.0.0-20210721160646-ee27cde735e2
f9b404d 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
vendor containerd v1.6.0-beta.1
0941921 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
update containerd binary to v1.6.0-beta.1
5e127f0 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max force-pushed the update-containerd branch 2 times, most recently from 5efd264 to e850690 Compare November 8, 2021 20:05
@crazy-max
update protobuf/grpc only
bb54f59 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

Ok after just updating grpc I've got the same issue so not linked to containerd itself. Found out this comment on swarmkit repo from @dperny and @cyli and was wondering if it could be linked? Tried to also upgrade grpc on swarmkit and regen protobuf but no changes.

@thaJeztah thaJeztah added this to the 21.xx milestone Nov 23, 2021
@crazy-max crazy-max mentioned this pull request Dec 2, 2021
Closed
@crazy-max crazy-max mentioned this pull request Feb 15, 2022
Merged
@thaJeztah
Copy link
Member

superseded by #43357, which was merged

@thaJeztah thaJeztah closed this Mar 16, 2022
@thaJeztah thaJeztah removed this from the 21.xx milestone Mar 16, 2022
@crazy-max crazy-max deleted the update-containerd branch March 26, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crazy-max @tonistiigi @thaJeztah