[25.0 backport] Set Created to 0001-01-01T00:00:00Z on older API versions

[neersighted]

• Backport of Set Created to 0001-01-01T00:00:00Z on older API versions #47374

This matches the prior behavior before 2a6ff3c.

This also updates the Swagger documentation for the current version to note that the field might be the empty string and what that means.

Fixes #47368

(if accepted, this should be backported to 25.x)

Changelog

- API: Populate a missing `Created` field in `GET /images/{id}/json` with `0001-01-01T00:00:00Z` for API version <= 1.43.

[neersighted]

Not sure why GHA isn't triggering on this PR; reopening to force it.

[tianon]

LGTM (thanks for the carry, y'all! ❤️)

[tianon]

These looked flaky, so I restarted them:

    --- FAIL: TestIntegration/TestCopyUnicodePath/worker=dockerd/frontend=builtin (2.22s)

=== FAIL: frontend/dockerfile TestIntegration (1.69s)
time="2024-02-14T16:30:12Z" level=info msg="trying next host - response was http.StatusNotFound" host="localhost:43997"
    run.go:266: copied docker.io/amd64/busybox:latest@sha256:023917ec6a886d0e8e15f28fb543515a5fcd8d938edb091e8147db4efed388ee to local mirror localhost:43997/library/busybox:latest
    run.go:266: copied docker.io/amd64/debian:bullseye-20230109-slim@sha256:1acb06a0c31fb467eb8327ad361f1091ab265e0bf26d452dea45dcb0c0ea5e75 to local mirror localhost:34287/amd64/bullseye-20230109-slim

    --- FAIL: TestIntegration/TestDockerIgnoreMissingProvenance/worker=dockerd-containerd/frontend=builtin (2.29s)

=== FAIL: frontend/dockerfile TestIntegration (2.21s)
time="2024-02-14T16:30:28Z" level=info msg="trying next host - response was http.StatusNotFound" host="localhost:45155"
    run.go:266: copied docker.io/amd64/busybox:latest@sha256:023917ec6a886d0e8e15f28fb543515a5fcd8d938edb091e8147db4efed388ee to local mirror localhost:45155/library/busybox:latest
    run.go:266: copied docker.io/amd64/debian:bullseye-20230109-slim@sha256:1acb06a0c31fb467eb8327ad361f1091ab265e0bf26d452dea45dcb0c0ea5e75 to local mirror localhost:41199/amd64/bullseye-20230109-slim

[tianon]

Moar:

=== Failed
=== FAIL: github.com/docker/docker/integration-cli TestDockerCLIPushSuite/TestPushToCentralRegistryUnauthorized (0.22s)
    docker_cli_push_test.go:236: assertion failed: strings.Contains(out, "Retrying") is true

=== FAIL: github.com/docker/docker/integration-cli TestDockerCLIPushSuite (0.38s)

=================================== FAILURES ===================================
________________________ PluginTest.test_inspect_plugin ________________________
docker/api/client.py:265: in _raise_for_status
    response.raise_for_status()
/usr/local/lib/python3.12/site-packages/requests/models.py:1021: in raise_for_status
    raise HTTPError(http_error_msg, response=self)
E   requests.exceptions.HTTPError: 404 Client Error: Not Found for url: http+docker://localhost/v1.44/plugins/vieux/sshfs:latest/json

The above exception was the direct cause of the following exception:
tests/integration/api_plugin_test.py:68: in test_inspect_plugin
    self.ensure_plugin_installed(SSHFS)
tests/integration/api_plugin_test.py:44: in ensure_plugin_installed
    return self.client.inspect_plugin(plugin_name)
docker/utils/decorators.py:32: in wrapper
    return f(self, *args, **kwargs)
docker/api/plugin.py:103: in inspect_plugin
    return self._result(self._get(url), True)
docker/api/client.py:271: in _result
    self._raise_for_status(response)
docker/api/client.py:267: in _raise_for_status
    raise create_api_error_from_http_exception(e) from e
docker/errors.py:39: in create_api_error_from_http_exception
    raise cls(e, response=response, explanation=explanation) from e
E   docker.errors.NotFound: 404 Client Error for http+docker://localhost/v1.44/plugins/vieux/sshfs:latest/json: Not Found ("plugin "vieux/sshfs:latest" not found")
_______ ContainerCollectionTest.test_run_with_image_that_does_not_exist ________
docker/api/client.py:265: in _raise_for_status
    response.raise_for_status()
/usr/local/lib/python3.12/site-packages/requests/models.py:1021: in raise_for_status
    raise HTTPError(http_error_msg, response=self)
E   requests.exceptions.HTTPError: 404 Client Error: Not Found for url: http+docker://localhost/v1.44/containers/create

The above exception was the direct cause of the following exception:
docker/models/containers.py:873: in run
    container = self.create(image=image, command=command,
docker/models/containers.py:[93](https://github.com/moby/moby/actions/runs/7904225191/job/21576379937?pr=47387#step:7:94)2: in create
    resp = self.client.api.create_container(**create_kwargs)
docker/api/container.py:439: in create_container
    return self.create_container_from_config(config, name, platform)
docker/api/container.py:456: in create_container_from_config
    return self._result(res, True)
docker/api/client.py:271: in _result
    self._raise_for_status(response)
docker/api/client.py:267: in _raise_for_status
    raise create_api_error_from_http_exception(e) from e
docker/errors.py:39: in create_api_error_from_http_exception
    raise cls(e, response=response, explanation=explanation) from e
E   docker.errors.ImageNotFound: 404 Client Error for http+docker://localhost/v1.44/containers/create: Not Found ("No such image: dockerpytest_does_not_exist:latest")

During handling of the above exception, another exception occurred:
docker/api/client.py:265: in _raise_for_status
    response.raise_for_status()
/usr/local/lib/python3.12/site-packages/requests/models.py:1021: in raise_for_status
    raise HTTPError(http_error_msg, response=self)
E   requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: http+docker://localhost/v1.44/images/create?tag=latest&fromImage=dockerpytest_does_not_exist

The above exception was the direct cause of the following exception:
tests/integration/models_containers_test.py:41: in test_run_with_image_that_does_not_exist
    client.containers.run("dockerpytest_does_not_exist")
docker/models/containers.py:876: in run
    self.client.images.pull(image, platform=platform)
docker/models/images.py:464: in pull
    pull_log = self.client.api.pull(
docker/api/image.py:429: in pull
    self._raise_for_status(response)
docker/api/client.py:267: in _raise_for_status
    raise create_api_error_from_http_exception(e) from e
docker/errors.py:39: in create_api_error_from_http_exception
    raise cls(e, response=response, explanation=explanation) from e
E   docker.errors.APIError: 500 Server Error for http+docker://localhost/v1.44/images/create?tag=latest&fromImage=dockerpytest_does_not_exist: Internal Server Error ("Get "https://registry-1.docker.io/v2/": read tcp 172.17.0.3:36884->54.196.99.49:443: read: connection reset by peer")
____________________ ImageCollectionTest.test_pull_with_sha ____________________
docker/api/client.py:265: in _raise_for_status
    response.raise_for_status()
/usr/local/lib/python3.12/site-packages/requests/models.py:1021: in raise_for_status
    raise HTTPError(http_error_msg, response=self)
E   requests.exceptions.HTTPError: 404 Client Error: Not Found for url: http+docker://localhost/v1.44/images/hello-world%40sha256:083de497cff[94](https://github.com/moby/moby/actions/runs/7904225191/job/21576379937?pr=47387#step:7:95)4f969d8499ab94f07134c50bcf5e6b[95](https://github.com/moby/moby/actions/runs/7904225191/job/21576379937?pr=47387#step:7:96)59b27182d3fa80ce3f7/json

The above exception was the direct cause of the following exception:
tests/integration/models_images_test.py:84: in test_pull_with_sha
    image = client.images.pull(image_ref)
docker/models/images.py:474: in pull
    return self.get(f'{repository}{sep}{tag}')
docker/models/images.py:333: in get
    return self.prepare_model(self.client.api.inspect_image(name))
docker/utils/decorators.py:19: in wrapped
    return f(self, resource_id, *args, **kwargs)
docker/api/image.py:251: in inspect_image
    return self._result(
docker/api/client.py:271: in _result
    self._raise_for_status(response)
docker/api/client.py:267: in _raise_for_status
    raise create_api_error_from_http_exception(e) from e
docker/errors.py:39: in create_api_error_from_http_exception
    raise cls(e, response=response, explanation=explanation) from e
E   docker.errors.ImageNotFound: 404 Client Error for http+docker://localhost/v1.44/images/hello-world%40sha256:083de497cff944f[96](https://github.com/moby/moby/actions/runs/7904225191/job/21576379937?pr=47387#step:7:97)9d8499ab94f07134c50bcf5e6b9559b27182d3fa80ce3f7/json: Not Found ("No such image: hello-world@sha256:083de4[97](https://github.com/moby/moby/actions/runs/7904225191/job/21576379937?pr=47387#step:7:98)cff944f969d8499ab94f07134c50bcf5e6b9559b27182d3fa80ce3f7")
=============================== warnings summary ===============================
tests/integration/client_test.py::CancellableEventsTest::test_cancel_events
  /src/docker/utils/utils.py:3[98](https://github.com/moby/moby/actions/runs/7904225191/job/21576379937?pr=47387#step:7:99): DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
    delta = dt - datetime.utcfromtimestamp(0)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
------- generated xml file: /src/bundles/test-docker-py/junit-report.xml -------
=========================== short test summary info ============================

=== FAIL: amd64.integration.system TestLoginFailsWithBadCredentials (0.74s)
    login_test.go:28: assertion failed: expected error to contain "unauthorized: incorrect username or password", got "Error response from daemon: Get \"[https://registry-1.docker.io/v2/\](https://registry-1.docker.io/v2//)": read tcp 172.17.0.3:35976->54.196.99.49:443: read: connection reset by peer"
        Error response from daemon: Get "https://registry-1.docker.io/v2/": read tcp 172.17.0.3:35976->54.196.99.49:443: read: connection reset by peer

=== FAIL: amd64.integration.image TestImagePullNonExisting/library/asdfasdf:foobar (0.25s)
    pull_test.go:187: assertion failed: expected error to contain "pull access denied for asdfasdf, repository does not exist or may require 'docker login'", got "Error response from daemon: Get \"[https://registry-1.docker.io/v2/library/asdfasdf/tags/list\](https://registry-1.docker.io/v2/library/asdfasdf/tags/list/)": EOF"
        Error response from daemon: Get "https://registry-1.docker.io/v2/library/asdfasdf/tags/list": EOF
    --- FAIL: TestImagePullNonExisting/library/asdfasdf:foobar (0.25s)

=== FAIL: amd64.integration.image TestImagePullNonExisting (0.01s)

[tianon]

lol

  /usr/bin/docker buildx inspect --bootstrap --builder builder-8da35b17-2903-49cc-b866-2ec71c7347ea
  #1 [internal] booting buildkit
  #1 pulling image moby/buildkit:buildx-stable-1 0.0s done
  #1 ERROR: Error response from daemon: Get "https://registry-1.docker.io/v2/": read tcp 10.1.0.153:43058->54.196.99.49:443: read: connection reset by peer
  ------
   > [internal] booting buildkit:
  ------
  ERROR: Error response from daemon: Get "https://registry-1.docker.io/v2/": read tcp 10.1.0.153:43058->54.196.99.49:443: read: connection reset by peer

[thaJeztah]

Once you experience "Da Flaky" you don't want anything else! Enjoy 😝😂

[thaJeztah]

LGTM

do we need release notes for this one?

[neersighted]

Added a release note.