feat: added TypeScript + ts-node/esm and tsx/esm examples #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JoshuaKGoldberg
changed the title
This was referenced Jan 21, 2024
Open
This was referenced Feb 6, 2024
FoxxMD
added a commit
to FoxxMD/multi-scrobbler
that referenced
this pull request
Feb 15, 2024
So that we can use tsx with official --import rather than requiring (old-style) which doesn't work with string-sameness esm for some reason mochajs/mocha#5002 mochajs/mocha-examples#76
|
tsx uses esbuild which doesn't support decorators. Whenever you have decorators in your code, don't use tsx/esbuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there wasn't yet an example that shows TypeScript transpilation on-the-fly with ESM imports/loaders. mochajs/mocha#5002 is a Mocha issue asking about support.
This adds two examples:
--import=tsx/esm: Newer--importflag for Node.js post-v18.19.0/v20.6.0--loader=ts-node/esm: Older--loaderflag for Node.jsFixes #75