Skip to content

Commit

Permalink
Remove stdout: prefix
Browse files Browse the repository at this point in the history
Fixes #2095, by disabling the `stdout:` prefix with the browser shim.
  • Loading branch information
skeggse authored and boneskull committed Sep 27, 2017
1 parent e39a867 commit 37193a4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion browser-entry.js
Expand Up @@ -7,7 +7,7 @@
* Shim process.stdout.
*/

process.stdout = require('browser-stdout')();
process.stdout = require('browser-stdout')({level: false});

var Mocha = require('./lib/mocha');

Expand Down

5 comments on commit 37193a4

@plroebuck
Copy link
Contributor

@plroebuck plroebuck commented on 37193a4 Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confused about this. Did this commit actually fix the problem (and if so, how?).
BrowserStdout doesn't seem to make any use of a level option, but rather a label option.

@skeggse, @mattflix, @boneskull ping concerning #2095!

@Bamieh
Copy link
Contributor

@Bamieh Bamieh commented on 37193a4 Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plroebuck True this should be label not level

@skeggse
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. I can't recall what I was working on, nor whether I even had the time to test this change. Please do open a PR to fix this!

@Bamieh
Copy link
Contributor

@Bamieh Bamieh commented on 37193a4 Sep 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skeggse @plroebuck done! check #3477

@plroebuck
Copy link
Contributor

@plroebuck plroebuck commented on 37193a4 Sep 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skeggse, how did you (intend to) test this fix? We should ensure it's really gone with #3477.

Can't believe no one noticed (commented) that the Mocha-4.0 release didn't fix the problem given its release notes.

Please sign in to comment.