Fix couple errors missing codes

mochajs · Jan 8, 2019 · 4e7f923 · boneskull · Jan 11, 2019 · 4e7f923
1 parent 9d62030
commit 4e7f923
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 4 deletions.
diff --git a/lib/cli/run.js b/lib/cli/run.js
@@ -11,6 +11,7 @@ const Mocha = require('../mocha');
 const ansi = require('ansi-colors');
 const errors = require('../errors');
 const createInvalidArgumentValueError = errors.createInvalidArgumentValueError;
+const createMissingArgumentError = errors.createMissingArgumentError;
 
 const {
   list,
@@ -258,15 +259,19 @@ exports.builder = yargs =>
 
       // yargs.implies() isn't flexible enough to handle this
       if (argv.invert && !('fgrep' in argv || 'grep' in argv)) {
-        throw new Error(
-          '"--invert" requires one of "--fgrep <str>" or "--grep <regexp>"'
+        throw createMissingArgumentError(
+          '"--invert" requires one of "--fgrep <str>" or "--grep <regexp>"',
+          '--invert',
+          argv.invert
         );
       }
 
       if (argv.compilers) {
-        throw new Error(
+        throw createInvalidArgumentValueError(
           `--compilers is DEPRECATED and no longer supported.
-          See ${ansi.cyan('https://git.io/vdcSr')} for migration information.`
+          See ${ansi.cyan('https://git.io/vdcSr')} for migration information.`,
+          '--compilers',
+          argv.compilers
         );
       }
 

diff --git a/test/integration/options.spec.js b/test/integration/options.spec.js
@@ -346,6 +346,26 @@ describe('options', function() {
           done();
         });
       });
+
+      it('fails if no --grep', function(done) {
+        args = ['--invert'];
+        runMocha(
+          'options/grep.fixture.js',
+          args,
+          function(err, res) {
+            if (err) {
+              done(err);
+              return;
+            }
+            expect(res, 'to satisfy', {
+              code: 1,
+              output: /fgrep/
+            });
+            done();
+          },
+          {stdio: 'pipe'}
+        );
+      });
     });
   });