fix leaking uncaughtException handler

mochajs · Jan 9, 2020 · 71ce33c · 71ce33c
1 parent 69339a3
commit 71ce33c
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/lib/runner.js b/lib/runner.js
@@ -908,9 +908,15 @@ Runner.prototype.run = function(fn) {
 
   fn = fn || function() {};
 
+  // uncaught exception within runner
   function uncaught(err) {
     self.uncaught(err);
   }
+  // uncaught exception after runner's end event
+  function uncaughtEnd(err) {
+    if (err instanceof Pending) return;
+    throw err;
+  }
 
   function start() {
     // If there is an `only` filter
@@ -940,17 +946,16 @@ Runner.prototype.run = function(fn) {
   this.on(constants.EVENT_RUN_END, function() {
     debug(constants.EVENT_RUN_END);
     process.removeListener('uncaughtException', uncaught);
-    process.on('uncaughtException', function(err) {
-      if (err instanceof Pending) {
-        return;
-      }
-      throw err;
-    });
+    process.on('uncaughtException', uncaughtEnd);
+    // console.log(process.listeners('uncaughtException'));
     fn(self.failures);
   });
 
   // uncaught exception
+  // process.removeListener('uncaughtException', uncaughtEnd); ?? does not work
+  process.removeAllListeners('uncaughtException');
   process.on('uncaughtException', uncaught);
+  // console.log(process.listeners('uncaughtException')[0]);
 
   if (this._delay) {
     // for reporters, I guess.