closes #3727

Fixes support for multiple node flags
mochajs · Mar 1, 2019 · 99ceb16 · 99ceb16
1 parent 22831c5
commit 99ceb16
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 1 deletion.
diff --git a/lib/cli/node-flags.js b/lib/cli/node-flags.js
@@ -81,5 +81,6 @@ exports.unparseNodeFlags = opts => {
         .split(/\b/)
         .map(arg => (arg === ' ' ? '=' : arg))
         .join('')
+        .split(' ')
     : [];
 };
diff --git a/test/node-unit/cli/node-flags.spec.js b/test/node-unit/cli/node-flags.spec.js
@@ -1,7 +1,11 @@
 'use strict';
 
 const nodeEnvFlags = require('node-environment-flags');
-const {isNodeFlag, impliesNoTimeouts} = require('../../../lib/cli/node-flags');
+const {
+  isNodeFlag,
+  impliesNoTimeouts,
+  unparseNodeFlags
+} = require('../../../lib/cli/node-flags');
 
 describe('node-flags', function() {
   describe('isNodeFlag()', function() {
@@ -86,4 +90,46 @@ describe('node-flags', function() {
       expect(impliesNoTimeouts('inspect-brk'), 'to be true');
     });
   });
+
+  describe('unparseNodeFlags()', function() {
+    it('should handle single v8 flags', function() {
+      expect(unparseNodeFlags({'v8-numeric': 100}), 'to equal', [
+        '--v8-numeric=100'
+      ]);
+      expect(unparseNodeFlags({'v8-boolean': true}), 'to equal', [
+        '--v8-boolean'
+      ]);
+    });
+
+    it('should handle multiple v8 flags', function() {
+      expect(
+        unparseNodeFlags({'v8-numeric-one': 1, 'v8-numeric-two': 2}),
+        'to equal',
+        ['--v8-numeric-one=1', '--v8-numeric-two=2']
+      );
+      expect(
+        unparseNodeFlags({'v8-boolean-one': true, 'v8-boolean-two': true}),
+        'to equal',
+        ['--v8-boolean-one', '--v8-boolean-two']
+      );
+      expect(
+        unparseNodeFlags({
+          'v8-boolean-one': true,
+          'v8-numeric-one': 1,
+          'v8-boolean-two': true
+        }),
+        'to equal',
+        ['--v8-boolean-one', '--v8-numeric-one=1', '--v8-boolean-two']
+      );
+      expect(
+        unparseNodeFlags({
+          'v8-numeric-one': 1,
+          'v8-boolean-one': true,
+          'v8-numeric-two': 2
+        }),
+        'to equal',
+        ['--v8-numeric-one=1', '--v8-boolean-one', '--v8-numeric-two=2']
+      );
+    });
+  });
 });