Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use semistandard #2490

Closed
boneskull opened this issue Sep 19, 2016 · 1 comment · Fixed by #2513
Closed

use semistandard #2490

boneskull opened this issue Sep 19, 2016 · 1 comment · Fixed by #2513

Comments

@boneskull
Copy link
Member

We have some code standards in place, but not enough. We have disabled many warnings which we probably shouldn't have, to avoid changing too much code when we picked up ESLint originally. I'd also prefer to use a widely-used style instead of a custom style.

  • Install eslint-semistandard-config and all necessary dependencies
  • Update .eslintrc to be just {"extends": "semistandard"}
  • eslint --fix everything
  • Manually fix everything else

If anyone disagrees, please let me know. Unless that disagreement involves "semicolons"; if so, please keep it to yourself. 😄

@boneskull boneskull added status: accepting prs Mocha can use your help with this one! qa labels Sep 19, 2016
@Munter
Copy link
Member

Munter commented Sep 19, 2016

Great move! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants