Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use semistandard #2513

Merged
merged 1 commit into from Oct 10, 2016
Merged

use semistandard #2513

merged 1 commit into from Oct 10, 2016

Conversation

makepanic
Copy link
Contributor

should fix #2490

@makepanic
Copy link
Contributor Author

makepanic commented Sep 30, 2016

I think there's a problem because config-semistandard and config-standard depend on eslint > 3.
Eslint > 3 requires node 4 or greater.

Nevermind, I think with some version pinning we could get it to work on old node.

@boneskull
Copy link
Member

boneskull commented Sep 30, 2016

I'm fine with requiring Node.js 4.x for linting (and newest ESLint). We only really need to run tests on multiple versions of Node.js--and even then, just in CI. We need to lint once.

Best way to accomplish that? Not sure. Maybe prepublish script which installs ESLint if the Node.js is new enough. Makefile should then check the version before trying to run it.

@makepanic
Copy link
Contributor Author

makepanic commented Sep 30, 2016

I rebased with some pinned versions which works on all our AppVeyor node versions, so it shouldn't be a problem anymore.

I could revert it for the lint target though.
What do you prefer?

@boneskull
Copy link
Member

fine as is for now. thanks a ton!

@boneskull boneskull merged commit d62b2b8 into mochajs:master Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use semistandard
2 participants